Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GalleryRef and Lightbox services #618

Open
MurhafSousli opened this issue Aug 27, 2024 · 0 comments
Open

Refactor GalleryRef and Lightbox services #618

MurhafSousli opened this issue Aug 27, 2024 · 0 comments
Labels
next major version

Comments

@MurhafSousli
Copy link
Owner

MurhafSousli commented Aug 27, 2024 •
edited
Loading

Rethink Gallery design

The singleton Gallery service will be removed.

Introduce a new function createGallery() that requires an items parameter and the options (optionally), then it returns a GalleryRefArgs, this will be used by the lightbox service to load items into the gallery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MurhafSousli and others