From 21c3723c6db9cff1e919a9ea69dd77776a255a53 Mon Sep 17 00:00:00 2001 From: vladsaveliev Date: Fri, 23 Feb 2024 14:54:51 +0100 Subject: [PATCH] Do not print info on every visit and visit persistence; set log level to debug only if ENVIRONMENT=DEV --- app/__init__.py | 2 +- app/main.py | 11 ++++------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/app/__init__.py b/app/__init__.py index 7bf6a7e..e94bf33 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -15,7 +15,7 @@ tmp_path = Path(os.getenv("TMPDIR", "/tmp")) log_path = tmp_path / "multiqc_api.log" logging.basicConfig( - level=logging.DEBUG, + level=logging.DEBUG if os.getenv("ENVIRONMENT") == "DEV" else logging.INFO, format="%(asctime)s - %(name)s - %(levelname)s - %(message)s", handlers=[ logging.StreamHandler(), diff --git a/app/main.py b/app/main.py index cfe7772..0019ebd 100644 --- a/app/main.py +++ b/app/main.py @@ -141,7 +141,7 @@ def _log_visit( "is_ci": is_ci, } ) - logger.info(f"Logging visit, total visits: {len(visit_buffer)}") + logger.debug(f"Logging visit, total visits: {len(visit_buffer)}") # Path to a buffer CSV file to persist recent visits before dumping to the database @@ -161,22 +161,19 @@ def _persist_visits() -> Response: with open(CSV_FILE_PATH, mode="r") as file: n_visits_file = sum(1 for _ in file) if not visit_buffer: - msg = f"No new visits to persist. File contains {n_visits_file} entries" - logger.info(msg) - return PlainTextResponse(content=msg) - logger.info( + return PlainTextResponse(content=f"No new visits to persist. File contains {n_visits_file} entries") + logger.debug( f"Appending {len(visit_buffer)} visits to {CSV_FILE_PATH} that currently contains {n_visits_file} visits" ) with open(CSV_FILE_PATH, mode="a") as file: writer: csv.DictWriter = csv.DictWriter(file, fieldnames=["timestamp"] + visit_fieldnames) writer.writerows(visit_buffer) - logger.info(f"Persisted {len(visit_buffer)} visits to CSV {CSV_FILE_PATH}") visit_buffer = [] with open(CSV_FILE_PATH, mode="r") as file: n_visits_file = sum(1 for _ in file) msg = f"Successfully persisted {len(visit_buffer)} visits to {CSV_FILE_PATH}, file now contains {n_visits_file} entries" - logger.info(msg) + logger.debug(msg) return PlainTextResponse(content=msg)