Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to import #95

Open
heyalexchoi opened this issue Jul 20, 2022 · 1 comment
Open

Unable to import #95

heyalexchoi opened this issue Jul 20, 2022 · 1 comment

Comments

@heyalexchoi
Copy link

Simple import and invocation breaks my app. package is installed and so are pods.

import { RNTwilioPhone } from 'react-native-twilio-phone'
console.log('RNTwilioPhone: ', RNTwilioPhone)
 ERROR  Invariant Violation: `new NativeEventEmitter()` requires a non-null argument.
 ERROR  TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[0], "./RNTwilioPhone").RNTwilioPhone')
@heyalexchoi
Copy link
Author

heyalexchoi commented Jul 21, 2022

ios project does not need firebase since that is only used for android. attempting to import firebase messaging in ios project breaks. issue. maybe this works if you actually install the pods and so on but there's a ton of subdependencies with special build configurations etc that I don't really want to deal with especially since that code will never even be called in an ios app.

this changes import of firebase messaging to conditional import since it is only conditionally used on android.

PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant