Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support #9

Open
4 tasks
Montellese opened this issue Jan 17, 2020 · 4 comments
Open
4 tasks

HTTPS support #9

Montellese opened this issue Jan 17, 2020 · 4 comments
Labels

Comments

@Montellese
Copy link
Owner

Montellese commented Jan 17, 2020

Right now the add-on only supports connecting to an Emby server using HTTP. HTTPS is not supported. It must also be possible to bypass HTTPS server certification validation by appending |verifypeer=false to URLs passed to Kodi.

  • How can the add-on determine that it should use HTTPS?
  • Make certificate verification configurable / optional.
    • Tell requests and websocket to ignore self-signed certificates.
    • Append |verifypeer=false to every URL directly used by Kodi.
@Montellese Montellese self-assigned this Jan 17, 2020
@Montellese Montellese removed their assignment Jan 28, 2020
@Montellese
Copy link
Owner Author

  • If the user manually adds the media provider and provides an HTTPS URL this seems to work in general.
  • If the media provider is auto-detected it always uses HTTP. How can the add-on determine that it should use HTTPS?
  • If the media provider uses a self-signed HTTPS certificate all requests directly from Kodi will fail and require |verifypeer=false in the URL.

@darthShadow
Copy link

Would it be possible to also consider HTTP/2 support as a part of this issue? Plugging in the hyper library into requests for HTTP/2 support is only a single-line addition and should be backwards compatible.

Documentation: https://hyper.readthedocs.io/en/latest/quickstart.html#requests-integration

I can create a separate issue for this if you would prefer that.

Thanks.

@Montellese
Copy link
Owner Author

Yes please create a separate issue. Do you happen to know whether hyper is available as a module in Kodi's python environment?

@darthShadow
Copy link

Done. #33

Do you happen to know whether hyper is available as a module in Kodi's python environment?
Sorry, not sure of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants