Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify fare_transfer_rule_with_forbidden_transfer_count so leg_group_id fields can be empty #1873

Open
emmambd opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature request or improvement on an existing feature status: Blocked Can't work on it currently because of an external factor.

Comments

@emmambd
Copy link
Contributor

emmambd commented Oct 7, 2024

Describe the problem

Currently, FareTransferRuleWithForbiddenTransferCountNotice triggers when both from_leg_group_id and to_leg_group_id are empty and transfer_count exists.

According to the spec, it should be ok to have transfer_count when from_leg_group_id and to_leg_group_id are empty.

Proposed solution

Modify fare_transfer_rule_with_forbidden_transfer_count so from_leg_group_id and to_leg_group_id can be empty when transfer count exists.

Alternatives you've considered

No response

Additional context

No response

@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels Oct 7, 2024
@emmambd emmambd added this to the 6.0 Validator Release milestone Oct 7, 2024
@emmambd emmambd added status: Blocked Can't work on it currently because of an external factor. and removed status: Needs triage Applied to all new issues labels Oct 7, 2024
@emmambd emmambd removed this from the 6.0 Validator Release milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature status: Blocked Can't work on it currently because of an external factor.
Projects
None yet
Development

No branches or pull requests

1 participant