Trees everywhere, mapgen bug

[gaelysam]

I've noticed yesterday with @Cyberpangolin that there are extremely dense forests everywhere in newly generated chunks. I've not taken screenshots but you can find such a forest at (-13800; -15000) for example. That seemed not normal to me, so I've tested on local with the same seed, and trees cover everything except ocean, savannah and desert.

This seems to be caused by the call to default.register_decorations. These decorations are biome-specific, but decorations are generated by minetest.generate_decorations, which doesn't takes the biomes into account. But I don't understand why it also places moretrees's huge jungle trees that are not registered by this function.

So I've purely and simply removed the call to default.register_decorations which creates the bug, and default.register_biomes which is useless (I think). It seems to work, even for moretrees's trees. But that's a quick fix, and I think we need to rework the decorations system in general. This should be merged in the server as soon as possible, as it affects all newly generated areas.

[Cyberpangolin]

Thanks for reporting!

[BetterToAutomateTheWorld]

Indeed i can see some problems in this area

moretrees + palmtrees bug in snow area + jungle + default snow trees in the same place, it's a problem...

Partly fixed here : 50956b5