Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Jar-in-Jar transitive dependencies resolvement #875

Open
realkarmakun opened this issue Jul 11, 2022 · 3 comments
Open

Implement Jar-in-Jar transitive dependencies resolvement #875

realkarmakun opened this issue Jul 11, 2022 · 3 comments
Assignees
@marchermans
Labels
feature request Requests a new feature to be added planned Feature or enhancement is planned

Comments

@realkarmakun
Copy link

realkarmakun commented Jul 11, 2022 •
edited
Loading

Right now transitive dependencies of libraries added with JiJ are not added to manifest, and should be explicitly added by mod developer.
@realkarmakun realkarmakun added the feature Adds a new feature to the codebase label Jul 11, 2022
@marchermans
Copy link
Contributor

Can somebody transfer this to FG, it is not an issue for Forge.

@covers1624 covers1624 transferred this issue from MinecraftForge/MinecraftForge Jul 15, 2022
@SizableShrimp SizableShrimp added planned Feature or enhancement is planned feature request Requests a new feature to be added and removed feature Adds a new feature to the codebase labels Jul 15, 2022
@marchermans
Copy link
Contributor

@realkarmakun What exactly do you mean here with manifest?

@MojangPlsFix
Copy link

MojangPlsFix commented Jun 19, 2023 •
edited
Loading

@realkarmakun What exactly do you mean here with manifest?

In the metadata.json. Transitive Dependencies are not added, but the jars itself are added.

Edit: This issue relates to #895 meaning it is rather a bug, then a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marchermans marchermans

Labels
feature request Requests a new feature to be added planned Feature or enhancement is planned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marchermans @MojangPlsFix @realkarmakun @SizableShrimp