Skip to content
This repository has been archived by the owner on May 18, 2024. It is now read-only.

Add CUSTOM version format #43

Open
tierriminator opened this issue Feb 16, 2023 · 1 comment
Open

Add CUSTOM version format #43

tierriminator opened this issue Feb 16, 2023 · 1 comment
Labels
core Issues adressing the finch library itself enhancement New feature or request

Comments

@tierriminator
Copy link
Contributor

Sometimes we would like to use input versions for formats which are currently not supported by finch.
The only option we then currently have is to provide the data as the source, from which we can only have one per input.
However, it should be possible to compare any dataformats, even ones which are not built into finch.

For example, let's assume we want to compare how the runtime is being affected when we use GRIB, compared to loading the data from some database (i.e. FDB).
Since we currently cannot write new GRIB versions, we cannot compare the two data formats.

We can solve this problem by adding a new CUSTOM data format, which can be added with Input.add_version().
When adding the new version, a function must be provided which defines how the data is retrieved.

We could even generalize this concept such that all input formats have a dedicated data retrieval function.

@tierriminator tierriminator added core Issues adressing the finch library itself enhancement New feature or request labels Feb 16, 2023
@tierriminator tierriminator added this to the Public Release milestone Feb 20, 2023
@tierriminator
Copy link
Contributor Author

Currently, we can provide multiple "unknown" input versions via a single source, because the requested version gets passed as an argument.
So we could actually compare GRIB with FDB by branching in the source between the two input versions, depending on some condition derived from the requested version object.
However, this functionality still provides its limits, since the current version class doesn't support a lot of configurable options as of now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Issues adressing the finch library itself enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant