Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Organize File' dialogue not properly initialized #4

Open
daed-alus opened this issue Apr 4, 2018 · 5 comments
Open

'Organize File' dialogue not properly initialized #4

daed-alus opened this issue Apr 4, 2018 · 5 comments

Comments

@daed-alus
Copy link

default selection in the 'Organize File' dialogue is not properly initialized
defaults to 'Series' but is not functional, only selecting 'blank' and than back to 'Series/Movie' initializes the lower input fields/buttons correctly

PoppyPop added a commit to PoppyPop/Emby.AutoOrganize that referenced this issue Apr 4, 2018
@PoppyPop
Copy link
Contributor

Do you still have th issue ? if yes, could you provide some more information :
Server / Plugin version
OS (Windows / lInux)
Browser
And if you can a javascript error log from your navigator.

I tried to reproduce with no success, do you have a huge library ? (tested with about 200 Series)

@daed-alus
Copy link
Author

no this does not occur anymore
but the selection defaults to 'movie', maybe this should be changed to 'blank'

@daed-alus daed-alus reopened this Apr 26, 2018
@daed-alus
Copy link
Author

daed-alus commented Apr 26, 2018

think this was not fixed and still took place but masked cause it always defaulted to 'movie' before and you had to switch anyway everytime

for a identified series episode file
unbenannt

for an identified movie file
unbenannt6

@n00b42
Copy link

n00b42 commented Nov 16, 2018

Still have the same issue. "Series" preselected but not initialized, first have to deselect then select again.

After click on the "Organize" button:
1

After deselecting the "Media Type"
2

After selecting "Series" again
3

@mathroc
Copy link

mathroc commented Dec 10, 2018

I looked a bit into this

I noticed this error:

TypeError: dlg.querySelector(...) is null; can't access its "innerHTML" property line 346

my guess is that's because selectedMediaTypeChanged is called before the browser is done rendering the dialog

maybe it should be called once it opened, eg:

dlg.addEventListener('open', function() {selectedMediaTypeChanged(dlg, item)})

but I don't know if the open event exists, or asynchronously, eg:

window.settimeout(function() {selectedMediaTypeChanged(dlg, item)}, 1);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants