Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsmasq disable causes a bad format line in dnsmasq.conf.add when guest network is used #28

Open
RavenSystem opened this issue Jul 22, 2024 · 1 comment · May be fixed by #29
Open

dnsmasq disable causes a bad format line in dnsmasq.conf.add when guest network is used #28

RavenSystem opened this issue Jul 22, 2024 · 1 comment · May be fixed by #29

Comments

@RavenSystem
Copy link

RavenSystem commented Jul 22, 2024 •
edited
Loading

  • Firmware: AsusWRT-Merlin 3004.388.8
  • Router: Asus GT-AX6000
  • Unbound Manager: v3.25

I configure Unbound to be the process that listen on port 53UDP, using dnsmasq disable in unbound_manager advanced.

This creates a new file at /jffs/configs/dnsmasq.conf.add.

I use guest networks, then this part is executed:

Unbound-Asuswrt-Merlin/unbound_manager.sh

Line 4751 in a3fa9ea

if [ $FIRMWARE -ge 38600 ];then # v3.22

br2 is my guest network. And a bad line is added to dnsmasq.conf.add file:

dhcp-option=br2,6,62.36.225.150 80.58.0.33      # unbound_manager

62.36.225.150 and 80.58.0.33 are my DNS servers from WAN config. And they are added because

Unbound-Asuswrt-Merlin/unbound_manager.sh

Line 4752 in a3fa9ea

ROUTER=$(nvram get wan0_dns) # v3.22

and...

Unbound-Asuswrt-Merlin/unbound_manager.sh

Line 4765 in a3fa9ea

[ -z "$(grep -F "dhcp-option=$BR,6,$ROUTER" /jffs/configs/dnsmasq.conf.add)" ] && echo -e "dhcp-option=$BR,6,$ROUTER # unbound_manager" >> /jffs/configs/dnsmasq.conf.add # v3.22

causing an error in dnsmasq process:
bad IPv4 address at line 37 of /etc/dnsmasq.conf
@RavenSystem RavenSystem changed the title dnsmasq disable causes a bad format line in dnsmasq.conf.add dnsmasq disable causes a bad format line in dnsmasq.conf.add when guest network is used Jul 22, 2024
@RavenSystem RavenSystem changed the title dnsmasq disable causes a bad format line in dnsmasq.conf.add when guest network is used dnsmasq disable causes a bad format line in dnsmasq.conf.add when guest network is used Jul 22, 2024
@RavenSystem RavenSystem linked a pull request Jul 24, 2024 that will close this issue
Open
@gregvis
Copy link

gregvis commented Feb 12, 2025

I had this bug happen to me. I tried the proposed pull request and it fixed the issue.

Please consider merging this and making a release. This issue completely makes the router dead in the water since unbound can't start and dnsmasq is disabled so there is no way to resolve dns addresses.

Perhaps there should be a check involved to check if unbound is running before dnsmasq is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@RavenSystem @gregvis