Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add Ollama Embedding #1070

Closed
rjwharry opened this issue Jan 18, 2025 · 2 comments · Fixed by #1071
Closed

[Feature Request] Add Ollama Embedding #1070

rjwharry opened this issue Jan 18, 2025 · 2 comments · Fixed by #1071
Assignees
@rjwharry
Labels
enhancement New feature or request

Comments

@rjwharry
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not supporting ollama for embedding model.
It may related to #985

Describe the solution you'd like
Fix the bug and add ollama for embedding model

Describe alternatives you've considered

Additional context
@rjwharry rjwharry added the enhancement New feature or request label Jan 18, 2025
@rjwharry
Copy link
Contributor Author

If you are willing to apply ollama, then please assign to me.

@vkehfdl1
Copy link
Contributor

@rjwharry Thank you! I assigned to you.
One thing, we changed a little bit to use embedding model recently. Not much changed, but please check #1063 #1063

@rjwharry rjwharry mentioned this issue Jan 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjwharry rjwharry

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add llama index's ollama embedding and fix type hint of embedding_model rjwharry/AutoRAG
2 participants
@vkehfdl1 @rjwharry