Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming <layer-> to <map-layer> #997

Closed
5 tasks
prushforth opened this issue Oct 16, 2024 · 0 comments · Fixed by #998
Closed
5 tasks

Consider renaming <layer-> to <map-layer> #997

prushforth opened this issue Oct 16, 2024 · 0 comments · Fixed by #998

Comments

@prushforth
Copy link
Member

prushforth commented Oct 16, 2024 •
edited
Loading

What would break? Changing it to <map-layer> would not strike people as weird when they first look at the language.
Add a list of things to change below:
@prushforth prushforth changed the title Consider renaming \<layer-> to \<map-layer> Consider renaming <layer-> to <map-layer> Oct 16, 2024
prushforth added a commit to prushforth/MapML.js that referenced this issue Oct 16, 2024
@prushforth
Close Maps4HTML#997 Refactors src and test and / to rename the layer-…
decf896 
… element to

map-layer.  Defines the window.MapML namespace containing the 
HTMLMap*Element classes, to be consistent with documented APIs.
@prushforth prushforth mentioned this issue Oct 16, 2024
Merged
prushforth added a commit to prushforth/MapML.js that referenced this issue Oct 16, 2024
@prushforth
Close Maps4HTML#997 Refactors src and test and / to rename the layer-…
8232d43 
… element to

map-layer.  Defines the window.MapML namespace containing the 
HTMLMap*Element classes, to be consistent with documented APIs.
prushforth added a commit to prushforth/MapML.js that referenced this issue Oct 16, 2024
@prushforth
Close Maps4HTML#997 Refactors src and test and / to rename the layer-…
4ddcd46 
… element to

map-layer.  Defines the window.MapML namespace containing the 
HTMLMap*Element classes, to be consistent with documented APIs.
prushforth added a commit that referenced this issue Oct 21, 2024
@prushforth
Close #997 Refactors src and test and / to rename the layer- element to
93966a2 
map-layer.  Defines the window.MapML namespace containing the 
HTMLMap*Element classes, to be consistent with documented APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename layer- to map-layer prushforth/MapML.js
1 participant
@prushforth