Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run Manim commands when it's started 2nd time (MacOS) #53

Closed
VladimirFokow opened this issue Oct 28, 2024 · 3 comments · Fixed by #66
Closed

Cannot run Manim commands when it's started 2nd time (MacOS) #53

VladimirFokow opened this issue Oct 28, 2024 · 3 comments · Fixed by #66
Assignees
Labels
before v1.0.0 bug Something isn't working

Comments

@VladimirFokow
Copy link
Collaborator

VladimirFokow commented Oct 28, 2024

On macOS, after starting Manim and then quitting it - it doesn't run again.


For example:

  • start a Manim window (with any method)
  • finish it (with any method)

After that - problems:

  • "Preview Manim Cell" -
    doesn't work, raises a notification:

    Simultaneous Manim commands are not currently
    supported on MacOS. Please wait for the current
    operations to finish before initiating a new command.

  • "Preview selection" command -
    doesn't work, same notification.

  • start manimgl via a terminal - works (it starts).
    But then the "Preview Manim Cell" , "Preview selection" commands continue NOT working - having the same behavior..

@VladimirFokow VladimirFokow changed the title [bug] 2nd time - doesn't start (macOS) [bug] 2nd time - doesn't run (macOS) Oct 28, 2024
@VladimirFokow VladimirFokow added bug Something isn't working before v1.0.0 labels Oct 28, 2024
@bhoov
Copy link
Collaborator

bhoov commented Oct 29, 2024

I can confirm this bug. Another important fix before release...

@VladimirFokow we should probably dive into the ManimShell.ts code to help @Splines with this implementation. He doesn't have a way to debug things on his end. It's actually quite frustrating these diff behaviors between WSL and MacOS -- I thought Electron was supposed to solve these issues 😂 lol

I suggest tackling some of the MacOS facing integration tests suggested in #47 as we try to resolve these OS conflicts. This is my first extension in VS Code, and it will also be my first attempt at testing in TS 🙈, but it will be very valuable. We can keep the tests local for now (i.e., running the suite on @Splines windows machines and our MacOS machines) and figure out how to integrate a CI pipeline later

@VladimirFokow
Copy link
Collaborator Author

VladimirFokow commented Oct 30, 2024

Log 1:

Manim Notebook.log

To show that:

  • 2nd time when manim is running:
    we can't execute code with manim notebook commands (they think the 1st session is still running)

Code:

from manimlib import *

class MyScene(Scene):
    def construct(self):
        #
        ## Test
        circle = Circle()
        self.play(ShowCreation(circle))

Steps:

  • reload window
  • start logging, select "manim notebook", "trace"
  • click "preview manim cell" (works fine: starts manim)
  • command: "quit preview"
  • click "preview manim cell" -> broken (shows warning, doesn't start manim, doesn't run)
  • command: start manim, on line 5 (works fine: starts manim)
  • click "preview manim cell" -> broken (shows warning, doesn't run)
  • select code and run it -> also broken (shows warning, doesn't run)

@Splines
Copy link
Member

Splines commented Oct 30, 2024

It's actually quite frustrating these diff behaviors between WSL and MacOS -- I thought Electron was supposed to solve these issues 😂 lol

@bhoov Yes, these differences are frustrating. But I'm not sure it's Electron's fault. We're dealing with a terminal and I suspect that communicating with underlying layers might reveal more difference shere than in other areas where "just" a regular Chromium browser is used and that is abstracted away in higher layers than the "bare-bone" terminal.


Here's what I did:

@VladimirFokow Thank you very much for the logfile and the enumeration of steps you've performed, this will hopefully make it possible for me to fix the issue in the following days.

@Splines Splines changed the title [bug] 2nd time - doesn't run (macOS) Cannot start Manim again after killing it (MacOS) Oct 30, 2024
@Splines Splines self-assigned this Oct 30, 2024
@VladimirFokow VladimirFokow changed the title Cannot start Manim again after killing it (MacOS) Cannot run Manim commands when it's started 2nd time (MacOS) Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before v1.0.0 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants