You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
For WLED (where multiple ESP devices are supported) I added a wrapper typedef methods to simplify coding effort while supporting single/non-parallel I2S for those devices. Similar to what is done for parallel I2S methods using X8xxxxxxxMethod or X16xxxxxxMethod.
It would be nice to have similar wrappers for single I2S methods.
I chose I2S1 for ESP32 since I2S0 is used by audio routines and I2S0 for S2. For S2 this unfortunately means that if user selects I2S output (last bus created) that audio will not function but this is of lesser importance as S2 only has single core and is not best suited for audio (audio is still available when only using 4 RMT outputs).
For S3 this is more of a workaround to still allow I2S compilation (it is impossible to select single I2S, only parallel).
For C3 devices (also supported by WLED but unsupported by NeoPixelBus ATM) I2S is excluded from compilation.
Describe alternatives you've considered
Multiple #ifdef or unsupported options.
I am also sure that having I2S1 for ESP32 and I2S0 for ESP32-S2 with these wrappers may not be to everyone's liking.
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
For WLED (where multiple ESP devices are supported) I added a wrapper
typedef
methods to simplify coding effort while supporting single/non-parallel I2S for those devices. Similar to what is done for parallel I2S methods usingX8xxxxxxxMethod
orX16xxxxxxMethod
.It would be nice to have similar wrappers for single I2S methods.
Describe the solution you'd like
I constructed:
I chose I2S1 for ESP32 since I2S0 is used by audio routines and I2S0 for S2. For S2 this unfortunately means that if user selects I2S output (last bus created) that audio will not function but this is of lesser importance as S2 only has single core and is not best suited for audio (audio is still available when only using 4 RMT outputs).
For S3 this is more of a workaround to still allow I2S compilation (it is impossible to select single I2S, only parallel).
For C3 devices (also supported by WLED but unsupported by NeoPixelBus ATM) I2S is excluded from compilation.
Describe alternatives you've considered
Multiple
#ifdef
or unsupported options.I am also sure that having I2S1 for ESP32 and I2S0 for ESP32-S2 with these wrappers may not be to everyone's liking.
Additional context
N/A
The text was updated successfully, but these errors were encountered: