Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER paramdefs #1

Open
Philiquaz opened this issue Feb 13, 2023 · 4 comments
Open

ER paramdefs #1

Philiquaz opened this issue Feb 13, 2023 · 4 comments

Comments

@Philiquaz
Copy link

Hi,
If you intend to maintain this, can you please keep paramdefs updated and switch to applyparamdefcarefully?
Thank you

@Philiquaz
Copy link
Author

Further, can you make the CSV files written and read by the program use all the fields in a param instead of omitting any

@MadProbe
Copy link
Owner

MadProbe commented Mar 15, 2023

  1. It already uses PARAMDEF.ApplyParamDefCarefully() even on original branch.
  2. Can you recommend sources for those paramdefs to keep them updated?

P.S. Apparently github didn't automatically subscribed to the watch list so sorry for late update and I would like to maintain this project.

@Philiquaz
Copy link
Author

That's interesting to hear. I can only imagine it was an issue with an earlier version of runebear that was fixed shortly before development stopped. The issue is many people still seem to run into issues with truncated params, and the common factor is those versions of yapped.
Going by this, I can assume this current version of yapped doesn't edit BuddyParam, SwordArtsParam, GameSystemCommonParam, FinalDamageRateParam, and maybe updates as old as ChrModelParam? If those do happen to still get loaded with the incomplete defs present... that'd be a soulsformats issue.

As for keeping paramdefs updated, keeping an eye on ?ServerName? when a patch drops would be the quickest.
I would love to say you could use https://github.com/soulsmods/paramdex, however that tends to not be updated frequently at all, with most fixes appearing on https://github.com/soulsmods/dsmapstudio instead (notably including defspatch, as mapstudio maintains support for multiple game versions at once)

@MadProbe
Copy link
Owner

MadProbe commented Apr 2, 2023

To be honest, the only issue I am experiencing is that they description & display names are in Japanese :/
Not sure how to get around that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants