LoggerWithFormatter missing 2nd param

[idc77]

This used to work

		oidcHandler := nethttpoidc.New(srv,
			options.WithIssuer(cfg.Issuer),
			options.WithRequiredTokenType("JWT"),
			options.WithRequiredAudience(cfg.Audience),
			options.IsPermissive(),
		)
		corshandler := cors.AllowAll()

		s := corshandler.Handler(
			httplog.LoggerWithFormatter(
				httplog.DefaultLogFormatterWithRequestHeader,
				oidcHandler,
			))

		return http.ListenAndServe(serveAddr, s)

now it doesn't anymore

Cannot use 'httplog.LoggerWithFormatter( httplog.DefaultLogFormatterWithRequestHeader, oidcHandler, )' (type func(next http.Handler) http.Handler) as the type http.Handler Type does not implement 'http.Handler' as some methods are missing: ServeHTTP(ResponseWriter, *Request)

github.com/MadAppGang/httplog v1.3.0
previous version v1.2.1

[erudenko]

Hi, sorry for the inconvenience.

Now it is simpler and you have two options:

You can user httplog.HandlerWithFormatter:

		s := corshandler.Handler(
			httplog.HandlerWithFormatter(
				httplog.DefaultLogFormatterWithRequestHeader,
				oidcHandler,
			))

Because Logger with formatted now returns logger middleware, you can reuse, the code will look something like that:

		oidcHandler := nethttpoidc.New(srv,
			options.WithIssuer(cfg.Issuer),
			options.WithRequiredTokenType("JWT"),
			options.WithRequiredAudience(cfg.Audience),
			options.IsPermissive(),
		)
                logger := httplog.LoggerWithFormatter(httplog.DefaultLogFormatterWithRequestHeader)
		corshandler := cors.AllowAll()

		s := corshandler.Handler(logger(oidcHandler))

		return http.ListenAndServe(serveAddr, s)