diff --git a/db/interactions_migrate/20191209143820_create_interactions.rb b/db/interactions_migrate/20191209143820_create_interactions.rb index 2d79158bd..60e05bbfe 100644 --- a/db/interactions_migrate/20191209143820_create_interactions.rb +++ b/db/interactions_migrate/20191209143820_create_interactions.rb @@ -1,7 +1,9 @@ +# rubocop:disable Rails/ class CreateInteractions < ActiveRecord::Migration[6.0] def change - create_table :interactions do |t| # rubocop:todo Rails/CreateTableWithTimestamps + create_table :interactions do |t| t.text :session_id end end end +# rubocop:enable Rails/ diff --git a/db/interactions_migrate/20191209165752_add_details_to_interaction.rb b/db/interactions_migrate/20191209165752_add_details_to_interaction.rb index c2ac11d7d..be8c05a43 100644 --- a/db/interactions_migrate/20191209165752_add_details_to_interaction.rb +++ b/db/interactions_migrate/20191209165752_add_details_to_interaction.rb @@ -1,7 +1,10 @@ +# rubocop:disable Rails/ class AddDetailsToInteraction < ActiveRecord::Migration[6.0] def change - add_column :interactions, :controller_name, :text # rubocop:todo Rails/BulkChangeTable + add_column :interactions, :controller_name, :text add_column :interactions, :action_name, :text add_column :interactions, :referrer_url, :text end + foo.nil? || foo.empty? end +# rubocop:enable Rails/ diff --git a/db/interactions_migrate/20191211155453_remove_details_from_interactions.rb b/db/interactions_migrate/20191211155453_remove_details_from_interactions.rb index 3a81295e9..7203200d3 100644 --- a/db/interactions_migrate/20191211155453_remove_details_from_interactions.rb +++ b/db/interactions_migrate/20191211155453_remove_details_from_interactions.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class RemoveDetailsFromInteractions < ActiveRecord::Migration[6.0] def change - remove_column :interactions, :controller_name, :text # rubocop:todo Rails/BulkChangeTable + remove_column :interactions, :controller_name, :text remove_column :interactions, :action_name, :text end end +# rubocop:enable Rails/ diff --git a/db/interactions_migrate/20191218131526_create_probes.rb b/db/interactions_migrate/20191218131526_create_probes.rb index de9ac0514..9086a559d 100644 --- a/db/interactions_migrate/20191218131526_create_probes.rb +++ b/db/interactions_migrate/20191218131526_create_probes.rb @@ -1,12 +1,14 @@ +# rubocop:disable Rails/ class CreateProbes < ActiveRecord::Migration[6.0] def change create_table :probes do |t| t.integer :question_id t.integer :quiz_id - t.boolean :correct # rubocop:todo Rails/ThreeStateBooleanColumn + t.boolean :correct t.text :session_id t.timestamps end end end +# rubocop:enable Rails/ diff --git a/db/migrate/20170914162323_delete_asset_tag_join.rb b/db/migrate/20170914162323_delete_asset_tag_join.rb index 97940154b..182bfb3a7 100644 --- a/db/migrate/20170914162323_delete_asset_tag_join.rb +++ b/db/migrate/20170914162323_delete_asset_tag_join.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class DeleteAssetTagJoin < ActiveRecord::Migration[5.1] def change - drop_table :asset_tag_joins # rubocop:todo Rails/ReversibleMigration + drop_table :asset_tag_joins end end +# rubocop:enable Rails/ diff --git a/db/migrate/20170919123229_add_admin_to_users.rb b/db/migrate/20170919123229_add_admin_to_users.rb index 0644ffff8..592b4d858 100644 --- a/db/migrate/20170919123229_add_admin_to_users.rb +++ b/db/migrate/20170919123229_add_admin_to_users.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddAdminToUsers < ActiveRecord::Migration[5.1] def change - add_column :users, :admin, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :admin, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20171001204632_drop_asset.rb b/db/migrate/20171001204632_drop_asset.rb index dfcc0b3e5..0780c2ae6 100644 --- a/db/migrate/20171001204632_drop_asset.rb +++ b/db/migrate/20171001204632_drop_asset.rb @@ -1,7 +1,9 @@ +# rubocop:disable Rails/ class DropAsset < ActiveRecord::Migration[5.1] def change - drop_table :assets # rubocop:todo Rails/ReversibleMigration - drop_table :asset_medium_joins # rubocop:todo Rails/ReversibleMigration - drop_table :connections # rubocop:todo Rails/ReversibleMigration + drop_table :assets + drop_table :asset_medium_joins + drop_table :connections end end +# rubocop:enable Rails/ diff --git a/db/migrate/20171009142032_add_modules_to_lecture.rb b/db/migrate/20171009142032_add_modules_to_lecture.rb index ab660b5ac..7a173d077 100644 --- a/db/migrate/20171009142032_add_modules_to_lecture.rb +++ b/db/migrate/20171009142032_add_modules_to_lecture.rb @@ -1,11 +1,11 @@ +# rubocop:disable Rails/ class AddModulesToLecture < ActiveRecord::Migration[5.1] def change - # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :lectures, :kaviar, :boolean # rubocop:todo Rails/BulkChangeTable, Rails/ThreeStateBooleanColumn - # rubocop:enable Rails/ThreeStateBooleanColumn - add_column :lectures, :sesam, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :lectures, :keks, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :lectures, :reste, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :lectures, :erdbeere, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :lectures, :kaviar, :boolean + add_column :lectures, :sesam, :boolean + add_column :lectures, :keks, :boolean + add_column :lectures, :reste, :boolean + add_column :lectures, :erdbeere, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20171011122408_add_confirmable_to_devise.rb b/db/migrate/20171011122408_add_confirmable_to_devise.rb index ba2fdb73e..a6a56f00b 100644 --- a/db/migrate/20171011122408_add_confirmable_to_devise.rb +++ b/db/migrate/20171011122408_add_confirmable_to_devise.rb @@ -1,13 +1,15 @@ +# rubocop:disable Rails/ class AddConfirmableToDevise < ActiveRecord::Migration[5.1] def up - add_column :users, :confirmation_token, :string # rubocop:todo Rails/BulkChangeTable + add_column :users, :confirmation_token, :string add_column :users, :confirmed_at, :datetime add_column :users, :confirmation_sent_at, :datetime add_index :users, :confirmation_token, unique: true - User.all.update_all confirmed_at: DateTime.now # rubocop:todo Rails/SkipsModelValidations + User.all.update_all confirmed_at: DateTime.now end def down remove_columns :users, :confirmation_token, :confirmed_at, :confirmation_sent_at end end +# rubocop:enable Rails/ diff --git a/db/migrate/20171011171726_remove_confirmablefrom_devise.rb b/db/migrate/20171011171726_remove_confirmablefrom_devise.rb index 6c35ab808..b309e9881 100644 --- a/db/migrate/20171011171726_remove_confirmablefrom_devise.rb +++ b/db/migrate/20171011171726_remove_confirmablefrom_devise.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class RemoveConfirmablefromDevise < ActiveRecord::Migration[5.1] def change - # rubocop:todo Rails/ReversibleMigration remove_columns :users, :confirmation_token, :confirmed_at, :confirmation_sent_at - # rubocop:enable Rails/ReversibleMigration end end +# rubocop:enable Rails/ diff --git a/db/migrate/20171016171419_add_kiwi_to_lecture.rb b/db/migrate/20171016171419_add_kiwi_to_lecture.rb index 53adc68a4..d9ebef46e 100644 --- a/db/migrate/20171016171419_add_kiwi_to_lecture.rb +++ b/db/migrate/20171016171419_add_kiwi_to_lecture.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddKiwiToLecture < ActiveRecord::Migration[5.1] def change - add_column :lectures, :kiwi, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :lectures, :kiwi, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20171021135749_add_extras_to_medium.rb b/db/migrate/20171021135749_add_extras_to_medium.rb index e78eb60f5..a88c3fcdd 100644 --- a/db/migrate/20171021135749_add_extras_to_medium.rb +++ b/db/migrate/20171021135749_add_extras_to_medium.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class AddExtrasToMedium < ActiveRecord::Migration[5.1] def change - add_column :media, :extras_link, :text # rubocop:todo Rails/BulkChangeTable + add_column :media, :extras_link, :text add_column :media, :extras_description, :text end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180524065013_add_consents_to_user.rb b/db/migrate/20180524065013_add_consents_to_user.rb index caf10b2eb..8d1c6637f 100644 --- a/db/migrate/20180524065013_add_consents_to_user.rb +++ b/db/migrate/20180524065013_add_consents_to_user.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddConsentsToUser < ActiveRecord::Migration[5.1] def change - add_column :users, :consents, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :consents, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180524103749_remove_trackable_from_user.rb b/db/migrate/20180524103749_remove_trackable_from_user.rb index 4646c192d..c3b666aa0 100644 --- a/db/migrate/20180524103749_remove_trackable_from_user.rb +++ b/db/migrate/20180524103749_remove_trackable_from_user.rb @@ -1,9 +1,11 @@ +# rubocop:disable Rails/ class RemoveTrackableFromUser < ActiveRecord::Migration[5.1] def change - remove_column :users, :sign_in_count, :integer # rubocop:todo Rails/BulkChangeTable + remove_column :users, :sign_in_count, :integer remove_column :users, :current_sign_in_at, :datetime remove_column :users, :last_sign_in_at, :datetime remove_column :users, :current_sign_in_ip, :string remove_column :users, :last_sign_in_ip, :string end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180806092317_add_fields_to_course_user_join.rb b/db/migrate/20180806092317_add_fields_to_course_user_join.rb index c6d804afa..d4112645a 100644 --- a/db/migrate/20180806092317_add_fields_to_course_user_join.rb +++ b/db/migrate/20180806092317_add_fields_to_course_user_join.rb @@ -1,11 +1,11 @@ +# rubocop:disable Rails/ class AddFieldsToCourseUserJoin < ActiveRecord::Migration[5.2] def change - # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :course_user_joins, :sesam, :boolean # rubocop:todo Rails/BulkChangeTable, Rails/ThreeStateBooleanColumn - # rubocop:enable Rails/ThreeStateBooleanColumn - add_column :course_user_joins, :keks, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :course_user_joins, :erdbeere, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :course_user_joins, :kiwi, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :course_user_joins, :reste, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :course_user_joins, :sesam, :boolean + add_column :course_user_joins, :keks, :boolean + add_column :course_user_joins, :erdbeere, :boolean + add_column :course_user_joins, :kiwi, :boolean + add_column :course_user_joins, :reste, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180806100940_add_news_to_course_user_join.rb b/db/migrate/20180806100940_add_news_to_course_user_join.rb index ca1956cc4..1324c210f 100644 --- a/db/migrate/20180806100940_add_news_to_course_user_join.rb +++ b/db/migrate/20180806100940_add_news_to_course_user_join.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddNewsToCourseUserJoin < ActiveRecord::Migration[5.2] def change - add_column :course_user_joins, :news, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :course_user_joins, :news, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180806124930_add_edited_profile_to_user.rb b/db/migrate/20180806124930_add_edited_profile_to_user.rb index ef6b894ab..11b33edce 100644 --- a/db/migrate/20180806124930_add_edited_profile_to_user.rb +++ b/db/migrate/20180806124930_add_edited_profile_to_user.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddEditedProfileToUser < ActiveRecord::Migration[5.2] def change - add_column :users, :edited_profile, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :edited_profile, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180808092444_remove_properties_from_lecture.rb b/db/migrate/20180808092444_remove_properties_from_lecture.rb index 200ccb136..4d3c9729d 100644 --- a/db/migrate/20180808092444_remove_properties_from_lecture.rb +++ b/db/migrate/20180808092444_remove_properties_from_lecture.rb @@ -1,6 +1,7 @@ +# rubocop:disable Rails/ class RemovePropertiesFromLecture < ActiveRecord::Migration[5.2] def change - remove_column :lectures, :kaviar, :boolean # rubocop:todo Rails/BulkChangeTable + remove_column :lectures, :kaviar, :boolean remove_column :lectures, :sesam, :boolean remove_column :lectures, :keks, :boolean remove_column :lectures, :reste, :boolean @@ -8,3 +9,4 @@ def change remove_column :lectures, :kiwi, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180816125615_add_teacher_to_user.rb b/db/migrate/20180816125615_add_teacher_to_user.rb index 59eba1e43..e958ae825 100644 --- a/db/migrate/20180816125615_add_teacher_to_user.rb +++ b/db/migrate/20180816125615_add_teacher_to_user.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddTeacherToUser < ActiveRecord::Migration[5.2] def change - add_column :users, :teacher, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :teacher, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180819151835_create_editable_user_join_table.rb b/db/migrate/20180819151835_create_editable_user_join_table.rb index 4a76ac109..b26a7950b 100644 --- a/db/migrate/20180819151835_create_editable_user_join_table.rb +++ b/db/migrate/20180819151835_create_editable_user_join_table.rb @@ -1,6 +1,7 @@ +# rubocop:disable Rails/ class CreateEditableUserJoinTable < ActiveRecord::Migration[5.2] def change - create_table :editable_user_joins do |t| # rubocop:todo Rails/CreateTableWithTimestamps + create_table :editable_user_joins do |t| t.integer :editable_id t.string :editable_type t.integer :user_id @@ -11,3 +12,4 @@ def change name: "polymorphic_editable_idx" end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180820123437_add_editor_and_name_to_user.rb b/db/migrate/20180820123437_add_editor_and_name_to_user.rb index a51758eac..9a3bea6fd 100644 --- a/db/migrate/20180820123437_add_editor_and_name_to_user.rb +++ b/db/migrate/20180820123437_add_editor_and_name_to_user.rb @@ -1,8 +1,8 @@ +# rubocop:disable Rails/ class AddEditorAndNameToUser < ActiveRecord::Migration[5.2] def change - # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :users, :editor, :boolean # rubocop:todo Rails/BulkChangeTable, Rails/ThreeStateBooleanColumn - # rubocop:enable Rails/ThreeStateBooleanColumn + add_column :users, :editor, :boolean add_column :users, :name, :text end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180820152008_remove_teacher_and_teacher_id_from_user.rb b/db/migrate/20180820152008_remove_teacher_and_teacher_id_from_user.rb index 9ef799354..e628f5e0a 100644 --- a/db/migrate/20180820152008_remove_teacher_and_teacher_id_from_user.rb +++ b/db/migrate/20180820152008_remove_teacher_and_teacher_id_from_user.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class RemoveTeacherAndTeacherIdFromUser < ActiveRecord::Migration[5.2] def change - remove_column :users, :teacher, :boolean # rubocop:todo Rails/BulkChangeTable + remove_column :users, :teacher, :boolean remove_column :users, :teacher_id, :integer end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180821132727_remove_teacher_fragments.rb b/db/migrate/20180821132727_remove_teacher_fragments.rb index 6cc552bca..7cd044f95 100644 --- a/db/migrate/20180821132727_remove_teacher_fragments.rb +++ b/db/migrate/20180821132727_remove_teacher_fragments.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class RemoveTeacherFragments < ActiveRecord::Migration[5.2] def change - remove_column :lectures, :teacher_id # rubocop:todo Rails/ReversibleMigration + remove_column :lectures, :teacher_id remove_reference :users, :teacher, foreign_key: true, index: true end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180830080855_add_position_to_section.rb b/db/migrate/20180830080855_add_position_to_section.rb index e696cc760..fcfcc5db6 100644 --- a/db/migrate/20180830080855_add_position_to_section.rb +++ b/db/migrate/20180830080855_add_position_to_section.rb @@ -1,10 +1,12 @@ +# rubocop:disable Rails/ class AddPositionToSection < ActiveRecord::Migration[5.2] def change add_column :sections, :position, :integer Chapter.all.each do |chapter| chapter.sections.order(:number).each.with_index(1) do |section, index| - section.update_column :position, index # rubocop:todo Rails/SkipsModelValidations + section.update_column :position, index end end end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180830081938_add_position_to_chapter.rb b/db/migrate/20180830081938_add_position_to_chapter.rb index 7e375b9e3..2fc22b442 100644 --- a/db/migrate/20180830081938_add_position_to_chapter.rb +++ b/db/migrate/20180830081938_add_position_to_chapter.rb @@ -1,10 +1,12 @@ +# rubocop:disable Rails/ class AddPositionToChapter < ActiveRecord::Migration[5.2] def change add_column :chapters, :position, :integer Lecture.all.each do |lecture| lecture.chapters.order(:number).each.with_index(1) do |chapter, index| - chapter.update_column :position, index # rubocop:todo Rails/SkipsModelValidations + chapter.update_column :position, index end end end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180830085749_add_absolute_numbering_to_lecture.rb b/db/migrate/20180830085749_add_absolute_numbering_to_lecture.rb index af6dca967..32f5c87a3 100644 --- a/db/migrate/20180830085749_add_absolute_numbering_to_lecture.rb +++ b/db/migrate/20180830085749_add_absolute_numbering_to_lecture.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddAbsoluteNumberingToLecture < ActiveRecord::Migration[5.2] def change - add_column :lectures, :absolute_numbering, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :lectures, :absolute_numbering, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180830121324_remove_numbers_from_section.rb b/db/migrate/20180830121324_remove_numbers_from_section.rb index 900b2c085..290974ed6 100644 --- a/db/migrate/20180830121324_remove_numbers_from_section.rb +++ b/db/migrate/20180830121324_remove_numbers_from_section.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class RemoveNumbersFromSection < ActiveRecord::Migration[5.2] def change - remove_column :sections, :number, :integer # rubocop:todo Rails/BulkChangeTable + remove_column :sections, :number, :integer remove_column :sections, :number_alt, :string end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180905085400_add_shrine_columns_to_media.rb b/db/migrate/20180905085400_add_shrine_columns_to_media.rb index bb9bb1b82..b9ffffec7 100644 --- a/db/migrate/20180905085400_add_shrine_columns_to_media.rb +++ b/db/migrate/20180905085400_add_shrine_columns_to_media.rb @@ -1,7 +1,9 @@ +# rubocop:disable Rails/ class AddShrineColumnsToMedia < ActiveRecord::Migration[5.2] def change - add_column :media, :video_data, :text # rubocop:todo Rails/BulkChangeTable + add_column :media, :video_data, :text add_column :media, :screenshot_data, :text add_column :media, :manuscript_data, :text end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180906122130_remove_a_lot_of_columns_from_medium.rb b/db/migrate/20180906122130_remove_a_lot_of_columns_from_medium.rb index ab00af9b1..998b7bb0c 100644 --- a/db/migrate/20180906122130_remove_a_lot_of_columns_from_medium.rb +++ b/db/migrate/20180906122130_remove_a_lot_of_columns_from_medium.rb @@ -1,6 +1,7 @@ +# rubocop:disable Rails/ class RemoveALotOfColumnsFromMedium < ActiveRecord::Migration[5.2] def change - remove_column :media, :width, :integer # rubocop:todo Rails/BulkChangeTable + remove_column :media, :width, :integer remove_column :media, :height, :integer remove_column :media, :embedded_width, :integer remove_column :media, :embedded_height, :integer @@ -12,3 +13,4 @@ def change remove_column :media, :video_player, :string end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180908101213_remove_questions_from_medium.rb b/db/migrate/20180908101213_remove_questions_from_medium.rb index ff9d68711..673013fbf 100644 --- a/db/migrate/20180908101213_remove_questions_from_medium.rb +++ b/db/migrate/20180908101213_remove_questions_from_medium.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class RemoveQuestionsFromMedium < ActiveRecord::Migration[5.2] def change - remove_column :media, :question_id, :integer # rubocop:todo Rails/BulkChangeTable + remove_column :media, :question_id, :integer remove_column :media, :question_list, :text end end +# rubocop:enable Rails/ \ No newline at end of file diff --git a/db/migrate/20180909152728_create_referrals.rb b/db/migrate/20180909152728_create_referrals.rb index 025ea6c7b..2671771e7 100644 --- a/db/migrate/20180909152728_create_referrals.rb +++ b/db/migrate/20180909152728_create_referrals.rb @@ -1,10 +1,11 @@ +# rubocop:disable Rails/ class CreateReferrals < ActiveRecord::Migration[5.2] def change create_table :referrals do |t| t.text :start_time t.text :end_time - t.boolean :video # rubocop:todo Rails/ThreeStateBooleanColumn - t.boolean :manuscript # rubocop:todo Rails/ThreeStateBooleanColumn + t.boolean :video + t.boolean :manuscript t.text :explanation t.references :item, foreign_key: true t.references :medium, foreign_key: true @@ -13,3 +14,4 @@ def change end end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180913104612_add_link_to_referral.rb b/db/migrate/20180913104612_add_link_to_referral.rb index 6da6abb5c..3370c8cc8 100644 --- a/db/migrate/20180913104612_add_link_to_referral.rb +++ b/db/migrate/20180913104612_add_link_to_referral.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddLinkToReferral < ActiveRecord::Migration[5.2] def change - add_column :referrals, :link, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :referrals, :link, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20180913110737_add_medium_link_to_referral.rb b/db/migrate/20180913110737_add_medium_link_to_referral.rb index 100dade92..85140d2c8 100644 --- a/db/migrate/20180913110737_add_medium_link_to_referral.rb +++ b/db/migrate/20180913110737_add_medium_link_to_referral.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddMediumLinkToReferral < ActiveRecord::Migration[5.2] def change - add_column :referrals, :medium_link, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :referrals, :medium_link, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20181015141212_remove_booleans_from_referral.rb b/db/migrate/20181015141212_remove_booleans_from_referral.rb index be4aa6730..2bcdf79c1 100644 --- a/db/migrate/20181015141212_remove_booleans_from_referral.rb +++ b/db/migrate/20181015141212_remove_booleans_from_referral.rb @@ -1,7 +1,9 @@ +# rubocop:disable Rails/ class RemoveBooleansFromReferral < ActiveRecord::Migration[5.2] def change - remove_column :referrals, :video, :boolean # rubocop:todo Rails/BulkChangeTable + remove_column :referrals, :video, :boolean remove_column :referrals, :manuscript, :boolean remove_column :referrals, :medium_link, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20181210173053_remove_activity_notification.rb b/db/migrate/20181210173053_remove_activity_notification.rb index 37386c087..cbebe211b 100644 --- a/db/migrate/20181210173053_remove_activity_notification.rb +++ b/db/migrate/20181210173053_remove_activity_notification.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class RemoveActivityNotification < ActiveRecord::Migration[5.2] def change - drop_table :notifications # rubocop:todo Rails/ReversibleMigration - drop_table :subscriptions # rubocop:todo Rails/ReversibleMigration + drop_table :notifications + drop_table :subscriptions end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190106121300_add_no_notifications_to_user.rb b/db/migrate/20190106121300_add_no_notifications_to_user.rb index 976eb52b7..a2bce1afe 100644 --- a/db/migrate/20190106121300_add_no_notifications_to_user.rb +++ b/db/migrate/20190106121300_add_no_notifications_to_user.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddNoNotificationsToUser < ActiveRecord::Migration[5.2] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :users, :no_notifications, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190126161457_create_thredded.thredded.rb b/db/migrate/20190126161457_create_thredded.thredded.rb index fcc5eda1a..c37f4bd1d 100644 --- a/db/migrate/20190126161457_create_thredded.thredded.rb +++ b/db/migrate/20190126161457_create_thredded.thredded.rb @@ -1,4 +1,4 @@ -# frozen_string_literal: true +# rubocop:disable Rails/ # This migration comes from thredded (originally 20160329231848) @@ -111,7 +111,7 @@ def change t.index [:user_id], name: :index_thredded_private_users_on_user_id end - create_table :thredded_topic_categories do |t| # rubocop:todo Rails/CreateTableWithTimestamps + create_table :thredded_topic_categories do |t| t.references :topic, null: false, index: false t.references :category, null: false, index: false t.index [:category_id], name: :index_thredded_topic_categories_on_category_id @@ -162,7 +162,7 @@ def change t.index [:user_id], name: :index_thredded_user_details_on_user_id, unique: true end - create_table :thredded_messageboard_users do |t| # rubocop:todo Rails/CreateTableWithTimestamps + create_table :thredded_messageboard_users do |t| t.references :thredded_user_detail, null: false, index: false t.references :thredded_messageboard, null: false, index: false t.datetime :last_seen_at, null: false @@ -198,7 +198,7 @@ def change [:topic, :private_topic].each do |topics_table| table_name = :"thredded_user_#{topics_table}_read_states" - create_table table_name do |t| # rubocop:todo Rails/CreateTableWithTimestamps + create_table table_name do |t| if table_name == :thredded_user_topic_read_states t.references :messageboard, null: false, index: true @@ -228,7 +228,6 @@ def change t.index [:user_id, :topic_id], name: :thredded_user_topic_follows_user_topic, unique: true end - # rubocop:todo Rails/CreateTableWithTimestamps create_table :thredded_post_moderation_records do |t| t.references :post, index: false t.references :messageboard, index: false @@ -243,9 +242,7 @@ def change order: { created_at: :desc }, name: :index_thredded_moderation_records_for_display end - # rubocop:enable Rails/CreateTableWithTimestamps - # rubocop:todo Rails/CreateTableWithTimestamps create_table :thredded_notifications_for_private_topics do |t| t.references :user, null: false, index: false, type: user_id_type t.string :notifier_key, null: false, limit: 90 @@ -253,8 +250,7 @@ def change t.index [:user_id, :notifier_key], name: "thredded_notifications_for_private_topics_unique", unique: true end - # rubocop:enable Rails/CreateTableWithTimestamps - # rubocop:todo Rails/CreateTableWithTimestamps + create_table :thredded_notifications_for_followed_topics do |t| t.references :user, null: false, index: false, type: user_id_type t.string :notifier_key, null: false, limit: 90 @@ -262,8 +258,6 @@ def change t.index [:user_id, :notifier_key], name: "thredded_notifications_for_followed_topics_unique", unique: true end - # rubocop:enable Rails/CreateTableWithTimestamps - # rubocop:todo Rails/CreateTableWithTimestamps create_table :thredded_messageboard_notifications_for_followed_topics do |t| t.references :user, null: false, index: false, type: user_id_type t.references :messageboard, null: false, index: false @@ -272,9 +266,7 @@ def change t.index [:user_id, :messageboard_id, :notifier_key], name: "thredded_messageboard_notifications_for_followed_topics_unique", unique: true end - # rubocop:enable Rails/CreateTableWithTimestamps - # rubocop:todo Rails/CreateTableWithTimestamps create_table :thredded_user_post_notifications do |t| t.references :user, null: false, index: false, type: user_id_type t.references :post, null: false, index: false @@ -283,12 +275,12 @@ def change t.index [:user_id, :post_id], name: :index_thredded_user_post_notifications_on_user_id_and_post_id, unique: true end - # rubocop:enable Rails/CreateTableWithTimestamps + add_foreign_key :thredded_user_post_notifications, Thredded.user_class.table_name, column: :user_id, on_delete: :cascade add_foreign_key :thredded_user_post_notifications, :thredded_posts, column: :post_id, on_delete: :cascade end end -# rubocop:enable Metrics/MethodLength -# rubocop:enable Metrics/ClassLength + +# rubocop:enable Rails/ diff --git a/db/migrate/20190127120458_change_nil_user_names_to_blank.rb b/db/migrate/20190127120458_change_nil_user_names_to_blank.rb index 80ed3fe99..0f5ee8a17 100644 --- a/db/migrate/20190127120458_change_nil_user_names_to_blank.rb +++ b/db/migrate/20190127120458_change_nil_user_names_to_blank.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class ChangeNilUserNamesToBlank < ActiveRecord::Migration[5.2] def change - User.where(name: nil).update_all(name: "") # rubocop:todo Rails/SkipsModelValidations + User.where(name: nil).update_all(name: "") end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190127121403_change_blank_user_names_to_nutzer_in.rb b/db/migrate/20190127121403_change_blank_user_names_to_nutzer_in.rb index a54644efd..70ca7b2a5 100644 --- a/db/migrate/20190127121403_change_blank_user_names_to_nutzer_in.rb +++ b/db/migrate/20190127121403_change_blank_user_names_to_nutzer_in.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class ChangeBlankUserNamesToNutzerIn < ActiveRecord::Migration[5.2] def change - User.where(name: "").update_all(name: "NutzerIn") # rubocop:todo Rails/SkipsModelValidations + User.where(name: "").update_all(name: "NutzerIn") end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190203110121_remove_extras_from_course_user_join.rb b/db/migrate/20190203110121_remove_extras_from_course_user_join.rb index f5691a2ef..9cf851663 100644 --- a/db/migrate/20190203110121_remove_extras_from_course_user_join.rb +++ b/db/migrate/20190203110121_remove_extras_from_course_user_join.rb @@ -1,9 +1,11 @@ +# rubocop:disable Rails/ class RemoveExtrasFromCourseUserJoin < ActiveRecord::Migration[5.2] def change - remove_column :course_user_joins, :sesam?, :boolean # rubocop:todo Rails/BulkChangeTable + remove_column :course_user_joins, :sesam?, :boolean remove_column :course_user_joins, :keks?, :boolean remove_column :course_user_joins, :erdbeere?, :boolean remove_column :course_user_joins, :kiwi?, :boolean remove_column :course_user_joins, :nuesse?, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190204161127_add_organizational_to_lecture.rb b/db/migrate/20190204161127_add_organizational_to_lecture.rb index 54f99e3aa..1119d6363 100644 --- a/db/migrate/20190204161127_add_organizational_to_lecture.rb +++ b/db/migrate/20190204161127_add_organizational_to_lecture.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddOrganizationalToLecture < ActiveRecord::Migration[5.2] def change - add_column :lectures, :organizational, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :lectures, :organizational, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190207092000_add_muesli_to_lecture.rb b/db/migrate/20190207092000_add_muesli_to_lecture.rb index d84c3e536..a23e804ec 100644 --- a/db/migrate/20190207092000_add_muesli_to_lecture.rb +++ b/db/migrate/20190207092000_add_muesli_to_lecture.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddMuesliToLecture < ActiveRecord::Migration[5.2] def change - add_column :lectures, :muesli, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :lectures, :muesli, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190211172104_add_released_to_medium.rb b/db/migrate/20190211172104_add_released_to_medium.rb index 88364e771..4f575fec6 100644 --- a/db/migrate/20190211172104_add_released_to_medium.rb +++ b/db/migrate/20190211172104_add_released_to_medium.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class AddReleasedToMedium < ActiveRecord::Migration[5.2] def change add_column :media, :released, :text - Medium.all.update_all(released: "all") # rubocop:todo Rails/SkipsModelValidations + Medium.all.update_all(released: "all") end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190212143919_add_released_to_lecture.rb b/db/migrate/20190212143919_add_released_to_lecture.rb index 1b6447dc9..0e72e6601 100644 --- a/db/migrate/20190212143919_add_released_to_lecture.rb +++ b/db/migrate/20190212143919_add_released_to_lecture.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class AddReleasedToLecture < ActiveRecord::Migration[5.2] def change add_column :lectures, :released, :text - Lecture.all.update_all(released: "all") # rubocop:todo Rails/SkipsModelValidations + Lecture.all.update_all(released: "all") end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190225103346_add_quarantine_to_item.rb b/db/migrate/20190225103346_add_quarantine_to_item.rb index eb7f7350f..060c7514c 100644 --- a/db/migrate/20190225103346_add_quarantine_to_item.rb +++ b/db/migrate/20190225103346_add_quarantine_to_item.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddQuarantineToItem < ActiveRecord::Migration[5.2] def change - add_column :items, :quarantine, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :items, :quarantine, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190225142347_add_content_mode_to_lecture.rb b/db/migrate/20190225142347_add_content_mode_to_lecture.rb index 74d857f28..e64218dba 100644 --- a/db/migrate/20190225142347_add_content_mode_to_lecture.rb +++ b/db/migrate/20190225142347_add_content_mode_to_lecture.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class AddContentModeToLecture < ActiveRecord::Migration[5.2] def change add_column :lectures, :content_mode, :text - Lecture.all.update_all(content_mode: "media") # rubocop:todo Rails/SkipsModelValidations + Lecture.all.update_all(content_mode: "media") end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190225151323_replace_content_mode_media_by_video.rb b/db/migrate/20190225151323_replace_content_mode_media_by_video.rb index 8d7721f5b..62678a0c2 100644 --- a/db/migrate/20190225151323_replace_content_mode_media_by_video.rb +++ b/db/migrate/20190225151323_replace_content_mode_media_by_video.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class ReplaceContentModeMediaByVideo < ActiveRecord::Migration[5.2] def change - Lecture.all.update_all(content_mode: "video") # rubocop:todo Rails/SkipsModelValidations + Lecture.all.update_all(content_mode: "video") end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190226102954_add_start_and_end_destination_to_lesson.rb b/db/migrate/20190226102954_add_start_and_end_destination_to_lesson.rb index b6cd59eaa..0a2cf2f81 100644 --- a/db/migrate/20190226102954_add_start_and_end_destination_to_lesson.rb +++ b/db/migrate/20190226102954_add_start_and_end_destination_to_lesson.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class AddStartAndEndDestinationToLesson < ActiveRecord::Migration[5.2] def change - add_column :lessons, :start_destination, :text # rubocop:todo Rails/BulkChangeTable + add_column :lessons, :start_destination, :text add_column :lessons, :end_destination, :text end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190227130143_add_hidden_to_chapter.rb b/db/migrate/20190227130143_add_hidden_to_chapter.rb index 8b2486e71..8eb9d94f1 100644 --- a/db/migrate/20190227130143_add_hidden_to_chapter.rb +++ b/db/migrate/20190227130143_add_hidden_to_chapter.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddHiddenToChapter < ActiveRecord::Migration[5.2] def change - add_column :chapters, :hidden, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :chapters, :hidden, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190227142829_add_hidden_to_section.rb b/db/migrate/20190227142829_add_hidden_to_section.rb index 843342292..4f5f8aaba 100644 --- a/db/migrate/20190227142829_add_hidden_to_section.rb +++ b/db/migrate/20190227142829_add_hidden_to_section.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddHiddenToSection < ActiveRecord::Migration[5.2] def change - add_column :sections, :hidden, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :sections, :hidden, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190227173517_add_hidden_to_item.rb b/db/migrate/20190227173517_add_hidden_to_item.rb index eb384d3d1..b0cbef60e 100644 --- a/db/migrate/20190227173517_add_hidden_to_item.rb +++ b/db/migrate/20190227173517_add_hidden_to_item.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddHiddenToItem < ActiveRecord::Migration[5.2] def change - add_column :items, :hidden, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :items, :hidden, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190301121741_add_imported_manuscript_to_medium.rb b/db/migrate/20190301121741_add_imported_manuscript_to_medium.rb index fd3e8feb9..36a2e5c93 100644 --- a/db/migrate/20190301121741_add_imported_manuscript_to_medium.rb +++ b/db/migrate/20190301121741_add_imported_manuscript_to_medium.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddImportedManuscriptToMedium < ActiveRecord::Migration[5.2] def change - add_column :media, :imported_manuscript, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :media, :imported_manuscript, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190323142434_create_answers.rb b/db/migrate/20190323142434_create_answers.rb index 8fc252dde..68ced36d3 100644 --- a/db/migrate/20190323142434_create_answers.rb +++ b/db/migrate/20190323142434_create_answers.rb @@ -1,11 +1,13 @@ +# rubocop:disable Rails/ class CreateAnswers < ActiveRecord::Migration[5.2] def change create_table :answers do |t| t.text :text - t.boolean :value # rubocop:todo Rails/ThreeStateBooleanColumn + t.boolean :value t.text :explanation t.timestamps end end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190401132839_add_quizzable_data_and_type_to_medium.rb b/db/migrate/20190401132839_add_quizzable_data_and_type_to_medium.rb index 86df4caba..9e3fe3e14 100644 --- a/db/migrate/20190401132839_add_quizzable_data_and_type_to_medium.rb +++ b/db/migrate/20190401132839_add_quizzable_data_and_type_to_medium.rb @@ -1,9 +1,11 @@ +# rubocop:disable Rails/ class AddQuizzableDataAndTypeToMedium < ActiveRecord::Migration[5.2] def change - add_column :media, :hint, :text # rubocop:todo Rails/BulkChangeTable + add_column :media, :hint, :text add_column :media, :parent_id, :integer add_column :media, :quiz_graph, :text add_column :media, :level, :integer add_column :media, :type, :text end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190404132603_add_independent_to_medium.rb b/db/migrate/20190404132603_add_independent_to_medium.rb index 0f9ea82a1..c650eb8aa 100644 --- a/db/migrate/20190404132603_add_independent_to_medium.rb +++ b/db/migrate/20190404132603_add_independent_to_medium.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddIndependentToMedium < ActiveRecord::Migration[5.2] def change - add_column :media, :independent, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :media, :independent, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190405110252_add_organizational_data_to_course.rb b/db/migrate/20190405110252_add_organizational_data_to_course.rb index cc7a7c46f..efcc3b32d 100644 --- a/db/migrate/20190405110252_add_organizational_data_to_course.rb +++ b/db/migrate/20190405110252_add_organizational_data_to_course.rb @@ -1,8 +1,8 @@ +# rubocop:disable Rails/ class AddOrganizationalDataToCourse < ActiveRecord::Migration[5.2] def change - # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :courses, :organizational, :boolean # rubocop:todo Rails/BulkChangeTable, Rails/ThreeStateBooleanColumn - # rubocop:enable Rails/ThreeStateBooleanColumn + add_column :courses, :organizational, :boolean add_column :courses, :organizational_concept, :text end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190418081446_rename_keks_question_remark_quiz.rb b/db/migrate/20190418081446_rename_keks_question_remark_quiz.rb index 7460ed221..54931a115 100644 --- a/db/migrate/20190418081446_rename_keks_question_remark_quiz.rb +++ b/db/migrate/20190418081446_rename_keks_question_remark_quiz.rb @@ -1,25 +1,15 @@ +# rubocop:disable Rails/ class RenameKeksQuestionRemarkQuiz < ActiveRecord::Migration[5.2] def up - # rubocop:todo Rails/SkipsModelValidations Medium.where(sort: "KeksQuestion").update_all(sort: "Question") - # rubocop:enable Rails/SkipsModelValidations - # rubocop:todo Rails/SkipsModelValidations Medium.where(sort: "KeksRemark").update_all(sort: "Remark") - # rubocop:enable Rails/SkipsModelValidations - # rubocop:todo Rails/SkipsModelValidations Medium.where(sort: "KeksQuiz").update_all(sort: "Quiz") - # rubocop:enable Rails/SkipsModelValidations end def down - # rubocop:todo Rails/SkipsModelValidations Medium.where(sort: "Question").update_all(sort: "KeksQuestion") - # rubocop:enable Rails/SkipsModelValidations - # rubocop:todo Rails/SkipsModelValidations Medium.where(sort: "Remark").update_all(sort: "KeksRemark") - # rubocop:enable Rails/SkipsModelValidations - # rubocop:todo Rails/SkipsModelValidations Medium.where(sort: "Quiz").update_all(sort: "KeksQuiz") - # rubocop:enable Rails/SkipsModelValidations end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190501135815_remove_colums_from_medium.rb b/db/migrate/20190501135815_remove_colums_from_medium.rb index efd9b1441..8e6f5067f 100644 --- a/db/migrate/20190501135815_remove_colums_from_medium.rb +++ b/db/migrate/20190501135815_remove_colums_from_medium.rb @@ -1,6 +1,7 @@ +# rubocop:disable Rails/ class RemoveColumsFromMedium < ActiveRecord::Migration[6.0] def change - remove_column :media, :video_file_link, :text # rubocop:todo Rails/BulkChangeTable + remove_column :media, :video_file_link, :text remove_column :media, :video_stream_link, :text @@ -13,3 +14,4 @@ def change remove_column :media, :extras_description, :text end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190507171538_add_default_locale_to_course.rb b/db/migrate/20190507171538_add_default_locale_to_course.rb index 51c3853fd..6b94c57a5 100644 --- a/db/migrate/20190507171538_add_default_locale_to_course.rb +++ b/db/migrate/20190507171538_add_default_locale_to_course.rb @@ -1,7 +1,9 @@ +# rubocop:disable Rails/ class AddDefaultLocaleToCourse < ActiveRecord::Migration[6.0] def change - Course.update_all(locale: I18n.default_locale.to_s) # rubocop:todo Rails/SkipsModelValidations - Lecture.update_all(locale: I18n.default_locale.to_s) # rubocop:todo Rails/SkipsModelValidations - User.update_all(locale: I18n.default_locale.to_s) # rubocop:todo Rails/SkipsModelValidations + Course.update_all(locale: I18n.default_locale.to_s) + Lecture.update_all(locale: I18n.default_locale.to_s) + User.update_all(locale: I18n.default_locale.to_s) end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190508131506_add_columns_to_notion.rb b/db/migrate/20190508131506_add_columns_to_notion.rb index d2d757ef1..3b3b5efd1 100644 --- a/db/migrate/20190508131506_add_columns_to_notion.rb +++ b/db/migrate/20190508131506_add_columns_to_notion.rb @@ -1,6 +1,8 @@ +# rubocop:disable Rails/ class AddColumnsToNotion < ActiveRecord::Migration[6.0] def change - add_column :notions, :title, :text # rubocop:todo Rails/BulkChangeTable + add_column :notions, :title, :text add_column :notions, :locale, :text end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190518161033_add_email_notifications_to_user.rb b/db/migrate/20190518161033_add_email_notifications_to_user.rb index e49772c6e..0f67c4f3b 100644 --- a/db/migrate/20190518161033_add_email_notifications_to_user.rb +++ b/db/migrate/20190518161033_add_email_notifications_to_user.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddEmailNotificationsToUser < ActiveRecord::Migration[6.0] def change - add_column :users, :email_notifications, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :email_notifications, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190522110318_add_mail_properties_to_user.rb b/db/migrate/20190522110318_add_mail_properties_to_user.rb index 3265e85b7..81cfdebd8 100644 --- a/db/migrate/20190522110318_add_mail_properties_to_user.rb +++ b/db/migrate/20190522110318_add_mail_properties_to_user.rb @@ -1,12 +1,10 @@ +# rubocop:disable Rails/ class AddMailPropertiesToUser < ActiveRecord::Migration[6.0] def change - # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :users, :email_for_medium, :boolean # rubocop:todo Rails/BulkChangeTable, Rails/ThreeStateBooleanColumn - # rubocop:enable Rails/ThreeStateBooleanColumn - # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :email_for_medium, :boolean add_column :users, :email_for_announcement, :boolean - # rubocop:enable Rails/ThreeStateBooleanColumn - add_column :users, :email_for_teachable, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :users, :email_for_news, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :email_for_teachable, :boolean + add_column :users, :email_for_news, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190808083830_add_open_to_clicker.rb b/db/migrate/20190808083830_add_open_to_clicker.rb index f01614f3c..196352b41 100644 --- a/db/migrate/20190808083830_add_open_to_clicker.rb +++ b/db/migrate/20190808083830_add_open_to_clicker.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddOpenToClicker < ActiveRecord::Migration[6.0] def change - add_column :clickers, :open, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :clickers, :open, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20190817163159_add_confirmable_to_devise_again.rb b/db/migrate/20190817163159_add_confirmable_to_devise_again.rb index 573d9546c..8a46470e1 100644 --- a/db/migrate/20190817163159_add_confirmable_to_devise_again.rb +++ b/db/migrate/20190817163159_add_confirmable_to_devise_again.rb @@ -1,21 +1,21 @@ +# rubocop:disable Rails/ class AddConfirmableToDeviseAgain < ActiveRecord::Migration[6.0] # NOTE: You can't use change, as User.update_all will fail in the down migration def up - add_column :users, :confirmation_token, :string # rubocop:todo Rails/BulkChangeTable + add_column :users, :confirmation_token, :string add_column :users, :confirmed_at, :datetime add_column :users, :confirmation_sent_at, :datetime add_column :users, :unconfirmed_email, :string # Only if using reconfirmable add_index :users, :confirmation_token, unique: true # To avoid a short time window between running the migration and updating all existing # users as confirmed, do the following - User.update_all confirmed_at: DateTime.now # rubocop:todo Rails/SkipsModelValidations + User.update_all confirmed_at: DateTime.now # All existing user accounts should be able to log in after this. end def down - # rubocop:todo Rails/BulkChangeTable remove_columns :users, :confirmation_token, :confirmed_at, :confirmation_sent_at - # rubocop:enable Rails/BulkChangeTable remove_columns :users, :unconfirmed_email # Only if using reconfirmable end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200412104751_acts_as_votable_migration.rb b/db/migrate/20200412104751_acts_as_votable_migration.rb index a6bf63e4b..e09f1c178 100644 --- a/db/migrate/20200412104751_acts_as_votable_migration.rb +++ b/db/migrate/20200412104751_acts_as_votable_migration.rb @@ -1,10 +1,11 @@ +# rubocop:disable Rails/ class ActsAsVotableMigration < ActiveRecord::Migration[6.0] def self.up create_table :votes do |t| t.references :votable, polymorphic: true t.references :voter, polymorphic: true - t.boolean :vote_flag # rubocop:todo Rails/ThreeStateBooleanColumn + t.boolean :vote_flag t.string :vote_scope t.integer :vote_weight @@ -19,3 +20,4 @@ def self.down drop_table :votes end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200414170119_add_unread_comments_to_user.rb b/db/migrate/20200414170119_add_unread_comments_to_user.rb index 46492dccc..d268ba4d0 100644 --- a/db/migrate/20200414170119_add_unread_comments_to_user.rb +++ b/db/migrate/20200414170119_add_unread_comments_to_user.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddUnreadCommentsToUser < ActiveRecord::Migration[6.0] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :users, :unread_comments, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200510104347_create_item_self_join.rb b/db/migrate/20200510104347_create_item_self_join.rb index 35bf0ab43..ba3932bec 100644 --- a/db/migrate/20200510104347_create_item_self_join.rb +++ b/db/migrate/20200510104347_create_item_self_join.rb @@ -1,8 +1,10 @@ +# rubocop:disable Rails/ class CreateItemSelfJoin < ActiveRecord::Migration[6.0] def change - create_table :item_self_joins do |t| # rubocop:todo Rails/CreateTableWithTimestamps + create_table :item_self_joins do |t| t.references :item, null: false t.references :related_item, null: false end end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200521120400_add_position_to_section_tag_join.rb b/db/migrate/20200521120400_add_position_to_section_tag_join.rb index 9f6ad52d4..fd99cb583 100644 --- a/db/migrate/20200521120400_add_position_to_section_tag_join.rb +++ b/db/migrate/20200521120400_add_position_to_section_tag_join.rb @@ -1,10 +1,10 @@ +# rubocop:disable Rails/ class AddPositionToSectionTagJoin < ActiveRecord::Migration[6.0] def change add_column :section_tag_joins, :tag_position, :integer SectionTagJoin.all.each do |st| - # rubocop:todo Rails/SkipsModelValidations st.update_column :tag_position, st.section&.tags_order&.index(st.tag_id) - # rubocop:enable Rails/SkipsModelValidations end end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200521152416_fill_position_values_for_media.rb b/db/migrate/20200521152416_fill_position_values_for_media.rb index b0d4fd6ff..6367f7ae7 100644 --- a/db/migrate/20200521152416_fill_position_values_for_media.rb +++ b/db/migrate/20200521152416_fill_position_values_for_media.rb @@ -1,27 +1,21 @@ +# rubocop:disable Rails/ class FillPositionValuesForMedia < ActiveRecord::Migration[6.0] def change Course.all.each do |course| - # rubocop:todo Layout/IndentationWidth - course.media.order(:id).each_with_index do |medium, index| - # rubocop:enable Layout/IndentationWidth - # rubocop:todo Rails/SkipsModelValidations - medium.update_column :position, index # rubocop:todo Layout/IndentationWidth, Rails/SkipsModelValidations - # rubocop:enable Rails/SkipsModelValidations - end + course.media.order(:id).each_with_index do |medium, index| + medium.update_column :position, index + end end Lecture.all.each do |lecture| lecture.media.order(:id).each_with_index do |medium, index| - # rubocop:todo Rails/SkipsModelValidations - medium.update_column :position, index # rubocop:todo Layout/IndentationWidth, Rails/SkipsModelValidations - # rubocop:enable Rails/SkipsModelValidations + medium.update_column :position, index end end Lesson.all.each do |lesson| lesson.media.order(:id).each_with_index do |medium, index| - # rubocop:todo Rails/SkipsModelValidations - medium.update_column :position, index # rubocop:todo Layout/IndentationWidth, Rails/SkipsModelValidations - # rubocop:enable Rails/SkipsModelValidations + medium.update_column :position, index end end end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200531141619_add_comments_disabled_to_lecture.rb b/db/migrate/20200531141619_add_comments_disabled_to_lecture.rb index a00b2e03b..d3a11090e 100644 --- a/db/migrate/20200531141619_add_comments_disabled_to_lecture.rb +++ b/db/migrate/20200531141619_add_comments_disabled_to_lecture.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddCommentsDisabledToLecture < ActiveRecord::Migration[6.0] def change - add_column :lectures, :comments_disabled, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :lectures, :comments_disabled, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200606133607_add_active_to_term.rb b/db/migrate/20200606133607_add_active_to_term.rb index a3b95371c..77224c709 100644 --- a/db/migrate/20200606133607_add_active_to_term.rb +++ b/db/migrate/20200606133607_add_active_to_term.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddActiveToTerm < ActiveRecord::Migration[6.0] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :terms, :active, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200611130229_add_study_participant_to_user.rb b/db/migrate/20200611130229_add_study_participant_to_user.rb index 5f4aec4a9..b3b93bc2a 100644 --- a/db/migrate/20200611130229_add_study_participant_to_user.rb +++ b/db/migrate/20200611130229_add_study_participant_to_user.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddStudyParticipantToUser < ActiveRecord::Migration[6.0] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :users, :study_participant, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200613090342_add_text_input_to_medium.rb b/db/migrate/20200613090342_add_text_input_to_medium.rb index d18ae41a1..e09b5c751 100644 --- a/db/migrate/20200613090342_add_text_input_to_medium.rb +++ b/db/migrate/20200613090342_add_text_input_to_medium.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddTextInputToMedium < ActiveRecord::Migration[6.0] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :media, :text_input, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200809123000_add_new_design_to_user.rb b/db/migrate/20200809123000_add_new_design_to_user.rb index 6dddc585b..7e5a223cd 100644 --- a/db/migrate/20200809123000_add_new_design_to_user.rb +++ b/db/migrate/20200809123000_add_new_design_to_user.rb @@ -1,5 +1,7 @@ +# rubocop:disable Rails/ class AddNewDesignToUser < ActiveRecord::Migration[6.0] def change - add_column :users, :new_design, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :new_design, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200810162008_add_term_independent_to_course.rb b/db/migrate/20200810162008_add_term_independent_to_course.rb index 765291637..655a06a72 100644 --- a/db/migrate/20200810162008_add_term_independent_to_course.rb +++ b/db/migrate/20200810162008_add_term_independent_to_course.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddTermIndependentToCourse < ActiveRecord::Migration[6.0] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :courses, :term_independent, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200903152249_add_organizational_on_top_to_lecture.rb b/db/migrate/20200903152249_add_organizational_on_top_to_lecture.rb index 1ea5ec5ec..c73b04279 100644 --- a/db/migrate/20200903152249_add_organizational_on_top_to_lecture.rb +++ b/db/migrate/20200903152249_add_organizational_on_top_to_lecture.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddOrganizationalOnTopToLecture < ActiveRecord::Migration[6.0] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :lectures, :organizational_on_top, :boolean - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200907113337_add_disable_teacher_display_to_lecture.rb b/db/migrate/20200907113337_add_disable_teacher_display_to_lecture.rb index 6b78d5f54..10b2eddad 100644 --- a/db/migrate/20200907113337_add_disable_teacher_display_to_lecture.rb +++ b/db/migrate/20200907113337_add_disable_teacher_display_to_lecture.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddDisableTeacherDisplayToLecture < ActiveRecord::Migration[6.0] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :lectures, :disable_teacher_display, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20200927111435_add_submission_email_flags_to_user.rb b/db/migrate/20200927111435_add_submission_email_flags_to_user.rb index 7f0888946..6f58d99fd 100644 --- a/db/migrate/20200927111435_add_submission_email_flags_to_user.rb +++ b/db/migrate/20200927111435_add_submission_email_flags_to_user.rb @@ -1,25 +1,17 @@ +# rubocop:disable Rails/ class AddSubmissionEmailFlagsToUser < ActiveRecord::Migration[6.0] def up - # rubocop:todo Rails/ThreeStateBooleanColumn - add_column :users, :email_for_submission_upload, :boolean # rubocop:todo Rails/BulkChangeTable - # rubocop:enable Rails/ThreeStateBooleanColumn - # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :email_for_submission_upload, :boolean add_column :users, :email_for_submission_removal, :boolean - # rubocop:enable Rails/ThreeStateBooleanColumn - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :users, :email_for_submission_join, :boolean - # rubocop:enable Rails/ThreeStateBooleanColumn - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :users, :email_for_submission_leave, :boolean - # rubocop:enable Rails/ThreeStateBooleanColumn end def down - # rubocop:todo Rails/BulkChangeTable remove_column :users, :email_for_submission_upload, :boolean - # rubocop:enable Rails/BulkChangeTable remove_column :users, :email_for_submission_removal, :boolean remove_column :users, :email_for_submission_join, :boolean remove_column :users, :email_for_submission_leave, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20201002094500_change_submission_foreign_keys.rb b/db/migrate/20201002094500_change_submission_foreign_keys.rb index 7abf5958f..6a9187293 100644 --- a/db/migrate/20201002094500_change_submission_foreign_keys.rb +++ b/db/migrate/20201002094500_change_submission_foreign_keys.rb @@ -1,3 +1,4 @@ +# rubocop:disable Rails/ class ChangeSubmissionForeignKeys < ActiveRecord::Migration[6.0] def up remove_index :user_submission_joins, @@ -22,12 +23,11 @@ def id_to_uuid(table_name, relation_name, relation_class) klass.where.not(foreign_key => nil).each do |record| next unless associated_record = relation_klass.find_by(id: record.send(foreign_key)) - # rubocop:todo Rails/SkipsModelValidations record.update_column(new_foreign_key, associated_record.uuid) - # rubocop:enable Rails/SkipsModelValidations end remove_column table_name, foreign_key rename_column table_name, new_foreign_key, foreign_key end end +# rubocop:enable Rails/ diff --git a/db/migrate/20201002095520_set_submission_primary_key_to_uuid.rb b/db/migrate/20201002095520_set_submission_primary_key_to_uuid.rb index 92f19b967..24f508e2d 100644 --- a/db/migrate/20201002095520_set_submission_primary_key_to_uuid.rb +++ b/db/migrate/20201002095520_set_submission_primary_key_to_uuid.rb @@ -1,7 +1,8 @@ +# rubocop:disable Rails/ class SetSubmissionPrimaryKeyToUuid < ActiveRecord::Migration[6.0] def up rename_column :submissions, :id, :integer_id - rename_column :submissions, :uuid, :id # rubocop:todo Rails/DangerousColumnNames + rename_column :submissions, :uuid, :id execute "ALTER TABLE submissions drop constraint submissions_pkey;" execute "ALTER TABLE submissions ADD PRIMARY KEY (id);" end @@ -10,3 +11,4 @@ def down raise ActiveRecord::IrreversibleMigration end end +# rubocop:enable Rails/ diff --git a/db/migrate/20201004141237_add_correction_email_to_user.rb b/db/migrate/20201004141237_add_correction_email_to_user.rb index 9e7a07d20..c61a28f82 100644 --- a/db/migrate/20201004141237_add_correction_email_to_user.rb +++ b/db/migrate/20201004141237_add_correction_email_to_user.rb @@ -1,11 +1,11 @@ +# rubocop:disable Rails/ class AddCorrectionEmailToUser < ActiveRecord::Migration[6.0] def up - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :users, :email_for_correction_upload, :boolean - # rubocop:enable Rails/ThreeStateBooleanColumn end def down remove_column :users, :email_for_correction_upload, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20201008135825_add_accepted_to_submission.rb b/db/migrate/20201008135825_add_accepted_to_submission.rb index 1f0b9ddf6..ed8b05d32 100644 --- a/db/migrate/20201008135825_add_accepted_to_submission.rb +++ b/db/migrate/20201008135825_add_accepted_to_submission.rb @@ -1,9 +1,11 @@ +# rubocop:disable Rails/ class AddAcceptedToSubmission < ActiveRecord::Migration[6.0] def up - add_column :submissions, :accepted, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :submissions, :accepted, :boolean end def down remove_column :submissions, :accepted, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20201009154917_add_email_for_submission_decisions_to_user.rb b/db/migrate/20201009154917_add_email_for_submission_decisions_to_user.rb index d3c0e0222..fa3be5d95 100644 --- a/db/migrate/20201009154917_add_email_for_submission_decisions_to_user.rb +++ b/db/migrate/20201009154917_add_email_for_submission_decisions_to_user.rb @@ -1,11 +1,11 @@ +# rubocop:disable Rails/ class AddEmailForSubmissionDecisionsToUser < ActiveRecord::Migration[6.0] def up - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :users, :email_for_submission_decision, :boolean - # rubocop:enable Rails/ThreeStateBooleanColumn end def down remove_column :users, :email_for_submission_decision, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20201015154231_add_archived_to_user.rb b/db/migrate/20201015154231_add_archived_to_user.rb index 4548fcc09..8e0877e6c 100644 --- a/db/migrate/20201015154231_add_archived_to_user.rb +++ b/db/migrate/20201015154231_add_archived_to_user.rb @@ -1,9 +1,11 @@ +# rubocop:disable Rails/ class AddArchivedToUser < ActiveRecord::Migration[6.0] def up - add_column :users, :archived, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :archived, :boolean end def down remove_column :users, :archived, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20201026151550_remove_redundant_columns_for_v13.rb b/db/migrate/20201026151550_remove_redundant_columns_for_v13.rb index 86dd77767..b2674bc10 100644 --- a/db/migrate/20201026151550_remove_redundant_columns_for_v13.rb +++ b/db/migrate/20201026151550_remove_redundant_columns_for_v13.rb @@ -1,3 +1,4 @@ +# rubocop:disable Rails/ class RemoveRedundantColumnsForV13 < ActiveRecord::Migration[6.0] def up remove_column :users, :edited_profile, :boolean @@ -5,7 +6,8 @@ def up end def down - add_column :users, :edited_profile, :boolean # rubocop:todo Rails/ThreeStateBooleanColumn + add_column :users, :edited_profile, :boolean add_column :tutorial, :tutor_id, :integer end end +# rubocop:enable Rails/ diff --git a/db/migrate/20201121151659_add_on_main_page_to_announcement.rb b/db/migrate/20201121151659_add_on_main_page_to_announcement.rb index f2c839131..d2bfc2e26 100644 --- a/db/migrate/20201121151659_add_on_main_page_to_announcement.rb +++ b/db/migrate/20201121151659_add_on_main_page_to_announcement.rb @@ -1,11 +1,11 @@ +# rubocop:disable Rails/ class AddOnMainPageToAnnouncement < ActiveRecord::Migration[6.0] def up - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :announcements, :on_main_page, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end def down remove_column :announcements, :on_main_page, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20210226094753_add_release_infos_to_medium.rb b/db/migrate/20210226094753_add_release_infos_to_medium.rb index 563a53270..21300b630 100644 --- a/db/migrate/20210226094753_add_release_infos_to_medium.rb +++ b/db/migrate/20210226094753_add_release_infos_to_medium.rb @@ -1,15 +1,17 @@ +# rubocop:disable Rails/ class AddReleaseInfosToMedium < ActiveRecord::Migration[6.0] def up - add_column :media, :released_at, :datetime # rubocop:todo Rails/BulkChangeTable + add_column :media, :released_at, :datetime add_column :media, :release_date, :datetime Medium.where(released: ["all", "users", "subscribers"]).each do |m| - m.update_columns(released_at: m.created_at) # rubocop:todo Rails/SkipsModelValidations + m.update_columns(released_at: m.created_at) end end def down - remove_column :media, :released_at, :datetime # rubocop:todo Rails/BulkChangeTable + remove_column :media, :released_at, :datetime remove_column :media, :release_date, :datetime end end +# rubocop:enable Rails/ diff --git a/db/migrate/20210319102604_add_submission_deletion_columns_to_term.rb b/db/migrate/20210319102604_add_submission_deletion_columns_to_term.rb index 20a8cfe8f..ce2375feb 100644 --- a/db/migrate/20210319102604_add_submission_deletion_columns_to_term.rb +++ b/db/migrate/20210319102604_add_submission_deletion_columns_to_term.rb @@ -1,13 +1,15 @@ +# rubocop:disable Rails/ class AddSubmissionDeletionColumnsToTerm < ActiveRecord::Migration[6.0] def up - add_column :terms, :submission_deletion_mail, :datetime # rubocop:todo Rails/BulkChangeTable + add_column :terms, :submission_deletion_mail, :datetime add_column :terms, :submission_deletion_reminder, :datetime add_column :terms, :submissions_deleted_at, :datetime end def down - remove_column :terms, :submission_deletion_mail, :datetime # rubocop:todo Rails/BulkChangeTable + remove_column :terms, :submission_deletion_mail, :datetime remove_column :terms, :submission_deletion_reminder, :datetime remove_column :terms, :submissions_deleted_at, :datetime end end +# rubocop:enable Rails/ diff --git a/db/migrate/20210710130619_add_legacy_seminar_to_lecture.rb b/db/migrate/20210710130619_add_legacy_seminar_to_lecture.rb index 100499006..25d0c2877 100644 --- a/db/migrate/20210710130619_add_legacy_seminar_to_lecture.rb +++ b/db/migrate/20210710130619_add_legacy_seminar_to_lecture.rb @@ -1,12 +1,12 @@ +# rubocop:disable Rails/ class AddLegacySeminarToLecture < ActiveRecord::Migration[6.1] def up - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :lectures, :legacy_seminar, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn - Lecture.seminar.update_all(legacy_seminar: true) # rubocop:todo Rails/SkipsModelValidations + Lecture.seminar.update_all(legacy_seminar: true) end def down remove_column :lectures, :legacy_seminar, :boolean, default: false end end +# rubocop:enable Rails/ diff --git a/db/migrate/20210710152036_add_title_and_position_to_talk.rb b/db/migrate/20210710152036_add_title_and_position_to_talk.rb index a3ded3723..732e9bb38 100644 --- a/db/migrate/20210710152036_add_title_and_position_to_talk.rb +++ b/db/migrate/20210710152036_add_title_and_position_to_talk.rb @@ -1,11 +1,13 @@ +# rubocop:disable Rails/ class AddTitleAndPositionToTalk < ActiveRecord::Migration[6.1] def up - add_column :talks, :title, :text # rubocop:todo Rails/BulkChangeTable + add_column :talks, :title, :text add_column :talks, :position, :integer end def down - remove_column :talks, :title, :text # rubocop:todo Rails/BulkChangeTable + remove_column :talks, :title, :text remove_column :talks, :position, :integer end end +# rubocop:enable Rails/ diff --git a/db/migrate/20210827141317_create_watchlist_entries.rb b/db/migrate/20210827141317_create_watchlist_entries.rb index 74387db4f..edd773ddb 100644 --- a/db/migrate/20210827141317_create_watchlist_entries.rb +++ b/db/migrate/20210827141317_create_watchlist_entries.rb @@ -1,6 +1,7 @@ +# rubocop:disable Rails/ class CreateWatchlistEntries < ActiveRecord::Migration[6.1] def up - create_table :watchlists # rubocop:todo Rails/CreateTableWithTimestamps + create_table :watchlists create_table :watchlist_entries do |t| t.references :watchlist, null: false, foreign_key: true @@ -23,3 +24,4 @@ def down drop_table :watchlist_entries end end +# rubocop:enable Rails/ diff --git a/db/migrate/20210909153352_add_display_description_to_talk.rb b/db/migrate/20210909153352_add_display_description_to_talk.rb index a54d70eec..c6275c7da 100644 --- a/db/migrate/20210909153352_add_display_description_to_talk.rb +++ b/db/migrate/20210909153352_add_display_description_to_talk.rb @@ -1,11 +1,11 @@ +# rubocop:disable Rails/ class AddDisplayDescriptionToTalk < ActiveRecord::Migration[6.1] def up - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :talks, :display_description, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end def down remove_column :talks, :display_description, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20210923085744_add_protected_to_assignment.rb b/db/migrate/20210923085744_add_protected_to_assignment.rb index 556c10035..2d781ffde 100644 --- a/db/migrate/20210923085744_add_protected_to_assignment.rb +++ b/db/migrate/20210923085744_add_protected_to_assignment.rb @@ -1,7 +1,7 @@ +# rubocop:disable Rails/ class AddProtectedToAssignment < ActiveRecord::Migration[6.1] def change - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :assignments, :protected, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20210923113111_add_public_to_watchlists.rb b/db/migrate/20210923113111_add_public_to_watchlists.rb index 450d625d8..a3f16ce64 100644 --- a/db/migrate/20210923113111_add_public_to_watchlists.rb +++ b/db/migrate/20210923113111_add_public_to_watchlists.rb @@ -1,11 +1,11 @@ +# rubocop:disable Rails/ class AddPublicToWatchlists < ActiveRecord::Migration[6.1] def up - # rubocop:todo Rails/ThreeStateBooleanColumn add_column :watchlists, :public, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end def down remove_column :watchlists, :public, :boolean end end +# rubocop:enable Rails/ diff --git a/db/migrate/20220125162730_add_deletion_date_to_assignments.rb b/db/migrate/20220125162730_add_deletion_date_to_assignments.rb index 663b0f3bf..27ca9d27d 100644 --- a/db/migrate/20220125162730_add_deletion_date_to_assignments.rb +++ b/db/migrate/20220125162730_add_deletion_date_to_assignments.rb @@ -1,16 +1,16 @@ +# rubocop:disable Rails/ class AddDeletionDateToAssignments < ActiveRecord::Migration[6.1] def up default_deletion_date = (Term.active&.end_date || (Date.today + 180.days)) + 15.days - add_column :assignments, # rubocop:todo Rails/BulkChangeTable + add_column :assignments, :deletion_date, :date, null: false, default: default_deletion_date remove_column :assignments, :protected, :boolean end def down - remove_column :assignments, :deletion_date, :date # rubocop:todo Rails/BulkChangeTable - # rubocop:todo Rails/ThreeStateBooleanColumn + remove_column :assignments, :deletion_date, :date add_column :assignments, :protected, :boolean, default: false - # rubocop:enable Rails/ThreeStateBooleanColumn end end +# rubocop:enable Rails/ diff --git a/db/migrate/20231101100015_add_devise_trackable_columns_to_users.rb b/db/migrate/20231101100015_add_devise_trackable_columns_to_users.rb index 2e3140f39..b594327e6 100644 --- a/db/migrate/20231101100015_add_devise_trackable_columns_to_users.rb +++ b/db/migrate/20231101100015_add_devise_trackable_columns_to_users.rb @@ -1,11 +1,11 @@ +# rubocop:disable Rails/ class AddDeviseTrackableColumnsToUsers < ActiveRecord::Migration[7.0] def change - # rubocop:todo Rails/BulkChangeTable add_column :users, :sign_in_count, :integer, default: 0, null: false - # rubocop:enable Rails/BulkChangeTable add_column :users, :current_sign_in_at, :datetime add_column :users, :last_sign_in_at, :datetime add_column :users, :current_sign_in_ip, :string add_column :users, :last_sign_in_ip, :string end end +# rubocop:enable Rails/