Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chgcentre #22

Open
d3v-null opened this issue Aug 17, 2023 · 1 comment
Open

Chgcentre #22

d3v-null opened this issue Aug 17, 2023 · 1 comment

Comments

@d3v-null
Copy link
Collaborator

Argument for vis convert

@cjordan
Copy link
Collaborator

cjordan commented Oct 27, 2023

Acktschually, an argument for InputVisArgs.

If it were me, I'd add a new struct member phase_centre: RADec to InputVisParams, and the value is set by the user argument to InputVisArgs, or if it's not specified, obs_context.phase_centre. Then all aspects of the code that currently use obs_context.phase_centre use input_vis_params.phase_centre instead.

Finally, the phase centre change actually needs to happen. I'd probably make a function that takes the old and new phase centres and an arbitrary chunk of visibilities, multiplying them by the correct factor. The work should probably be done immediately after each call to read_timestep in src/params/input_vis.rs. Check if any phase rotation needs to happen at all as it's not cheap.

The phase centre should be clarified as always being in the J2000 frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants