-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecated call to HttpRequest.get_raw_uri. Closes #2296 #2302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this @rafgia. It looks like there is a typo in the code (it should be build_absolute_uri()
, not build_absolut_uri()
).
Sorry @rafgia I should have picked this up before, but you'll see that the tests are still failing, now with the following error:
The problem is that function calls inside a template do not require the parentheses |
(Side note, you can run the tests locally with |
Thanks Raffaele, looks good and tests are now passing. Before we merge, please could you squash your commits? You could do this with:
|
Looks great, thanks Raffaele! |
According to the Django Release Notes at https://django.readthedocs.io/en/stable/releases/4.0.html:
This pull request replaces calls to HttpRequest.get_raw_uri with HttpRequest.build_absolute_uri() on the 404.html page. Closes #2296