Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on Python 3.12 not stated in environment.yml #47

Closed
davidosterberg opened this issue Oct 30, 2024 · 2 comments
Closed

Dependency on Python 3.12 not stated in environment.yml #47

davidosterberg opened this issue Oct 30, 2024 · 2 comments

Comments

@davidosterberg
Copy link

davidosterberg commented Oct 30, 2024 •
edited
Loading

Library no longer works with Python 3.11. This is the default python in for example Debian 12.

image

  1. typing.overide was added in 3.12 (https://peps.python.org/pep-0698/) is it intentional to break the library because of a typing feature. Seems like the benefits do not justify the inconvenience to users
  2. environment.yml does not state the dependency, so the library will download fine, but will be broken.
@davidosterberg davidosterberg changed the title Dependency on Python 3.12 not stated in pyproject.toml Dependency on Python 3.12 not stated in environment.yml Oct 30, 2024
davidosterberg added a commit to davidosterberg/metocean-api that referenced this issue Oct 30, 2024
@davidosterberg
Update environment.yml Fixes MET-OM#47
6dc2c21 
Honestly I am not sure it is reasonable to require 3.12 at this time. Many users are stuck on lower python versions. 

Anyway, fixes MET-OM#47
@davidosterberg davidosterberg mentioned this issue Oct 30, 2024
Closed
@lassebje
Copy link
Collaborator

@davidosterberg This is already being adressed in this pull request #45. It was a mistake to rely on python 12+ specific syntax. This should have been caught by the CI-system.

@lassebje
Copy link
Collaborator

lassebje commented Oct 31, 2024 •
edited
Loading

Suggest to won't fix this issue now as the override annotations has been removed in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update environment.yml Fixes #47 davidosterberg/metocean-api
2 participants
@davidosterberg @lassebje