Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show disabled geolocate button for browsers not collecting location #53

Open
atomtay opened this issue Mar 12, 2020 · 1 comment
Open

Comments

@atomtay
Copy link

atomtay commented Mar 12, 2020

As part of the move to 1.5.0, Mapbox GL JS displays a disabled icon when the browser denies geolocate permissions. We are currently using 0.47.0, so the Geolocate spinner either goes on aimlessly (Safari) or immediately switches back to its default resting state (Firefox). The React wrapper for Geolocate depends upon the mapbox-gl library, so both must be updated.

@atomtay
Copy link
Author

atomtay commented Mar 23, 2020

I have an hunch that this is related to the order in which we pull in packages; the example for React's geolocate wrapper doesn't include an explicit call to mapbox-gl in its package.json, but the site itself is pulling in the v1.8.1 CSS. I believe ours pulls in v1.2.1. I made an issue in the React Map GL repo here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant