Show icon if there is white/black list for a function

[an0n981]

If an app (in this case com.github.mobile) has Inet/Connect restricted an onDemand enabled and a list of whitelisted IPs, and then the onDemand check is removed (which IMO now means Inet/Connect should be completely restricted), the list of whitelisted IPs are still reachable. Is this a bug or a feature?
If this is a feature, and I need to collect ten +1 for a feature change to be considered, please let me know

[M66B]

I consider this as a bug, so no +1's needed.

[danielmmmm]

Oh, in that case I misunderstood how the whitelist works.
Do you mean to say that the whitelist only works when onDemand for connect is active?
I thought I could allow connections to some IPs by whitelisting them, then disable onDemand for connect, and thereby allow connections to whitelisted IPs, while rejecting all other IPs without getting a pop-up? Otherwise, apps would always ask to connect to unwanted IPs and one would always have to "deny for 15 seconds".

[an0n981]

@danielmmmm you can also blacklist items by clicking whitelist and deny

[danielmmmm]

Oh wow! I must be very ignorant to miss that. Thanks, this is extremely useful :-)

[M66B]

I cannot reproduce this issue, but it could be very well that #1653 also fixed this issue.

[M66B]

Please let me know if this issues still exists in version 2.0.23

[an0n981]

Yes issue still exists

[M66B]

Please tell me exactly how I can reproduce this.

[an0n981]

Install GitHub (only app I actually tested this with). Restrict Connect onDemand. Allow the GitHib IPs. Then remove the onDemand check (Inet/Connect=Deny). GitHub can still access the previously whitelisted IPs

[M66B]

Okay, then I misunderstood the issue.
This behavior is to be expected.
The IP is still whitelisted/blacklisted.
You can use whitelist management to delete whitelist entries.
(non pro users need to clear all restrictions for the application).

[an0n981]

IMHO if I remove the onDemand then white/blacklist should no longer be active, Since I have set Inet/Connect to deny

[M66B]

The white/blacklist is not dependent on on demand restricting being enabled or not.

[wbedard]

While apparently not a bug, I think that an0n981 is trying to say that is an "error in implementation", which I tend to agree with.

[M66B]

If this is a missing feature or not is debatable. That on demand restricting needs to be enabled to create whitelist entries doesn't necessarily imply that on demand restricting needs to be enabled to apply whitelist entries. Adding this condition will not only make the code more complex (which is at that point already complex enough), but could also affect performance, which are the main reasons I don't want to change this.

[M66B]

Maybe it is an idea to show an icon that there are whitelist entries active instead. Any suggestion for an icon is welcome.

[an0n981]

I don't know where you could put an icon, but what about a toast when an onDemand is unchecked that has white listed items?

[M66B]

I was thinking to display a small icon before the check boxes.
Clicking it would open whitelist management for pro version users.

[wbedard]

[Edited]Retracted post since it wasn't very accurate/good. Will think about the issue a bit more before posting...

[banderos101]

@M66B

"I was thinking to display a small icon before the check boxes.
Clicking it would open whitelist management for pro version users."

I think that would be a pretty convinient feature for the whitelist/blacklist feature

[M66B]

Does somebody have a proposal of a free to use icon or can somebody create an icon for this purpose?

[an0n981]

Should the icon have the same size as the pngs in res/drawable? I will see if I can create one. But it won't be before Friday. Tomorrow is a holiday here :) and I want to get paid for creating an icon.

[M66B]

You mean you want to create an icon during idle time while working I guess ;-)
Make it the same size as the book icon and it will be okay.

[M66B]

The code is finished, so waiting for a holo light and dark icon ...

[an0n981]

Is this related? XPrivacy / res / drawable / whitelist_holo_dark.png

[M66B]

Yes, that is a copy of the info icon I used for testing and needs to be replaced by another icon.
There is a light and dark one for the light and dark theme.

[an0n981]

But this is what we are looking at size wise?

[M66B]

Yes, that is why I copied the info icon.
Same size, type and colors to keep it consistent.
I am curious what symbol you are coming up with ;-)

[M66B]

BTW, I have edited your comment, since it contained your e-mail address.

[an0n981]

appreciate that 👍

[M66B]

That seems to happen if you reply to a GitHub notification (which I never do).
Maybe it can be changed with a GitHub setting.

[an0n981]

Since I couldn't decide on one really cool icon, I created a few different icons. Feel free to chose which one to use. Or maybe someone else has an even better idea
https://mega.co.nz/#!M54wnbaL!UIQrFdtBO-TTVKWH-MPa5CcBbWRdEVHwDHAsfy_l87o

[M66B]

I have chosen for number six, test version: http://www.xprivacy.eu/XPrivacy_2.0.26-2.apk

[an0n981]

Very nice! It even opens directly to the proper list.

[M66B]

Yes, I have made that as well for the convenience of everybody.
Thanks for the icons.

[an0n981]

It even knows when to show and when not 👍

[M66B]

Wasn't that the whole point? ;-)

[an0n981]

I was expecting an icon that indicates whether or not white lists are possible. I did not envision something so awesome

[M66B]

I don't like half work ...

[M66B]

Sometimes I think it is easier to chat, if you feel the same: GTalk: marcel ... faircode.eu
Replace ... by an at sign.

[an0n981]

I will ping you