Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

FAQ#10 misleading #1551

Closed
an0n981 opened this issue Mar 13, 2014 · 9 comments
Closed

FAQ#10 misleading #1551

an0n981 opened this issue Mar 13, 2014 · 9 comments
Labels

Comments

@an0n981
Copy link
Contributor

an0n981 commented Mar 13, 2014

Only restricting shell/su doesn't always disable root access. 2 qucick examples: jackpal.androidterm uses a native library and org.adaway uses shell/exec to gain root access

I would do a pull request but GitHub app is not very user friendly

@M66B M66B closed this as completed in 8c0672d Mar 13, 2014
@M66B
Copy link
Owner

M66B commented Mar 13, 2014

I have improved matching of the sh and su commands and updated the description. Could you be so kind to test this version and let me know of the su and sh are always matched okay?
http://d-h.st/ChR

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 13, 2014

Please advise as to how to test this. Google translate refuses to translate Java to English so don't really know what to look for.

@M66B
Copy link
Owner

M66B commented Mar 13, 2014

Simply by checking if shell/sh, shell/su and shell/exec are triggered with the correct commands.
For example AdAway should show su now instead of exec.
With on demand this is most easily checked, since it shows the command.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 13, 2014

With AdAway it now shows su. However another app com.jrummy.liberty.toolboxpro still shows sh to access root. It also has a lite version if you want to verify this.

@M66B
Copy link
Owner

M66B commented Mar 13, 2014

What is the command for com.jrummy.liberty.toolboxpro?

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 13, 2014

shell/sh at startup

once I actually attempt to do anything in the app (disable a broadcast receiver) then it asks for su

so I'm assuming this actually is correct?

Edit: but that would mean that app is still accessing root via shell on startup

@M66B
Copy link
Owner

M66B commented Mar 13, 2014

Yes, the su detection is not perfect.
To be sure, check the exact parameter in the usage data.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 13, 2014

for shell/sh parameter sh
for shell/su parameter su

@M66B
Copy link
Owner

M66B commented Mar 13, 2014

Then it is as good as it can be ;-)

@M66B M66B added the bug label Mar 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants