Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use two branches to separate ros1 and ros2 #26

Closed
Ericsii opened this issue Mar 1, 2023 · 2 comments
Closed

Why not use two branches to separate ros1 and ros2 #26

Ericsii opened this issue Mar 1, 2023 · 2 comments

Comments

@Ericsii
Copy link

Ericsii commented Mar 1, 2023

Why don't you open two branches to separately support ROS1 and ROS2? In order to directly compile the driver use catkin build or colcon build like any other ROS repos.

@Livox-Infra
Copy link
Collaborator

We do not separate ROS1 and ROS2 Driver because most of the code are the same.
Soon we would provide a new 'build script', which enable user to use catkin build or colcon build like other ROS repos (but still not to separate branches)

@rdu-weston
Copy link

rdu-weston commented Nov 15, 2023

We do not separate ROS1 and ROS2 Driver because most of the code are the same. Soon we would provide a new 'build script', which enable user to use catkin build or colcon build like other ROS repos (but still not to separate branches)

Honestly, providing a build script is not a very great idea. Yes, it simplifies the building by not asking users to manually do the steps in the script, but on the other hand you're forcing users to follow a non-ROS-conventional way to handle packages. It's fine if you only keep the Livox packages in this workspace but not so convenient if you also have other packages, which I believe is the more common case. Would you consider accepting #46 and merging it as soon as possible? @Livox-Infra

@Ericsii Ericsii closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants