From db6c7aa8d42a244f0e84c931c1cd19ca57eadeb5 Mon Sep 17 00:00:00 2001 From: Tim Hobson Date: Wed, 18 Dec 2024 17:29:13 +0000 Subject: [PATCH] Align test assertions with canonical resources --- tests/test_pipeline.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/test_pipeline.py b/tests/test_pipeline.py index 09c7ba90..05374a00 100644 --- a/tests/test_pipeline.py +++ b/tests/test_pipeline.py @@ -291,7 +291,7 @@ def test_deezy_rel_wpubl_wmtops(tmp_path): assert predictions.candidates()[0].mention.ner_score == 1.0 @pytest.mark.resources(reason="Needs large resources") -def test_perfect_rel_wpubl_wmtops(tmp_path): +def test_perfect_rel_wpubl_wmtops(): model_path = os.path.join(current_dir, "../resources/models/") assert os.path.isdir(model_path) is True @@ -362,23 +362,23 @@ def test_perfect_rel_wpubl_wmtops(tmp_path): assert resolved.candidates()[1].mention.ner_score == 1.0 assert resolved.candidates()[1].best_match() is not None assert isinstance(resolved.candidates()[1].best_match(), PredictedLinks) - assert resolved.candidates()[1].best_match().best_disambiguation_score() == pytest.approx(0.356, abs=1e-3) + assert resolved.candidates()[1].best_match().best_disambiguation_score() == pytest.approx(0.578, abs=1e-3) assert resolved.candidates()[1].best_wqid() == "Q39121" - assert resolved.candidates()[1].best_disambiguation_score() == pytest.approx(0.356, abs=1e-3) + assert resolved.candidates()[1].best_disambiguation_score() == pytest.approx(0.578, abs=1e-3) assert resolved.rel_scores[1].mention == "Leeds" - assert resolved.rel_scores[1].confidence == pytest.approx(0.0445, abs=1e-3) - assert resolved.rel_scores[1].scores["Q39121"] == pytest.approx(0.356, abs=1e-3) + assert resolved.rel_scores[1].confidence == pytest.approx(0.0688, abs=1e-3) + assert resolved.rel_scores[1].scores["Q39121"] == pytest.approx(0.578, abs=1e-3) assert resolved.candidates()[2].mention.mention == "London" assert resolved.candidates()[2].mention.ner_score == 0.998 assert resolved.candidates()[2].best_match() is not None assert isinstance(resolved.candidates()[1].best_match(), PredictedLinks) - assert resolved.candidates()[2].best_match().best_disambiguation_score() == pytest.approx(0.493, abs=1e-3) + assert resolved.candidates()[2].best_match().best_disambiguation_score() == pytest.approx(0.611, abs=1e-3) assert resolved.candidates()[2].best_wqid() == "Q84" - assert resolved.candidates()[2].best_disambiguation_score() == pytest.approx(0.493, abs=1e-3) + assert resolved.candidates()[2].best_disambiguation_score() == pytest.approx(0.611, abs=1e-3) assert resolved.rel_scores[2].mention == "London" - assert resolved.rel_scores[2].confidence == pytest.approx(0.0443, abs=1e-3) - assert resolved.rel_scores[2].scores["Q84"] == pytest.approx(0.493, abs=1e-3) + assert resolved.rel_scores[2].confidence == pytest.approx(0.0696, abs=1e-3) + assert resolved.rel_scores[2].scores["Q84"] == pytest.approx(0.611, abs=1e-3) @pytest.mark.resources(reason="Needs large resources") def test_modular_deezy_rel(tmp_path):