Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In emacs-macport, only switches to dark theme when Dark Mode is toggled #53

Open
what-the-functor opened this issue May 18, 2024 · 1 comment
Labels
bug Something isn't working macos

Comments

@what-the-functor
Copy link

what-the-functor commented May 18, 2024

If emacs-macport is launched when Dark Mode is active, the theme is not switched to the dark theme.
However, if I toggle Dark Mode (off, then on) the theme is switched.

The emacs-macport hook mac-effective-appearance-change-hook is set to auto-dark--check-and-set-dark-mode. This is working very well, though only when Dark Mode is actively toggled.

The aforementioned hook is not invoked when emacs starts, so there should be a mechanism at startup to check and set the dark mode.
In my configuration, I've solved this by adding auto-dark--check-and-set-dark-mode to emacs-startup-hook, though there is a flash of the light theme. I think that the flash of light can be avoided by utilising before-make-frame-hook in early-init.el.

@what-the-functor what-the-functor changed the title In emacs-macport, only switches to dark theme whenl Dark Mode is toggled In emacs-macport, only switches to dark theme when Dark Mode is toggled May 18, 2024
@LionyxML LionyxML added bug Something isn't working macos labels Jun 21, 2024
@sellout
Copy link
Contributor

sellout commented Oct 18, 2024

I‘m curious whether #74 fixes this for you.

I’m also curious (regardless of whether you test #74) what your configuration looks like. E.g.,

(use-package auto-dark
  :custom (auto-dark-dark-theme 'meh-dark)
  :init (auto-dark-mode))

or

(auto-dark-mode 1)

(custom-set-variables
 '(auto-dark-dark-theme 'meh-dark))

or

(custom-set-variables
 '(auto-dark-dark-theme 'meh-dark))

(auto-dark-mode 1)

or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macos
Projects
None yet
Development

No branches or pull requests

3 participants