Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROI support in LiveContext.run_udf #71

Open
matbryan52 opened this issue Mar 9, 2023 · 0 comments
Open

ROI support in LiveContext.run_udf #71

matbryan52 opened this issue Mar 9, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@matbryan52
Copy link
Member

Currently we have no support for using a nav-space ROI during live processing, and the behaviour is undocumented / implicitly allowed via the normal signature of run_. At least in my testing using a non-full ROI results in PipelineExecutor 'dropped tasks' or incorrect number of frames-type errors. For the moment we could add a warning (or even an exception) if roi is not None or contains zeros, on LiveContext.

That said, if we can find a way to handle an ROI there might be benefits in performance, as we're not required to buffer or process all frames, though speaking to @sk1p this isn't a guarantee.

One real use case for ROIs are cameras for which the data stream contains 'bad' frames, like a column of flyback frames or a line at the end of the scan which should be dropped (needed for trigger timing reasons). In particular for Ptychography having bad frames like that could negatively impact the reconstruction. On a more basic level it can also throw off plot colormap scaling.

@matbryan52 matbryan52 added bug Something isn't working enhancement New feature or request labels Mar 9, 2023
@matbryan52 matbryan52 changed the title ROI support in ctx.run_udf ROI support in LiveContext.run_udf Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant