Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove potion effects from draughts on PvP/PvE #358

Open
DwarfyAssassin opened this issue Aug 11, 2019 · 0 comments
Open

Remove potion effects from draughts on PvP/PvE #358

DwarfyAssassin opened this issue Aug 11, 2019 · 0 comments
Labels
improvement For improvements regarding existing features medium priority For something with medium priority

Comments

@DwarfyAssassin
Copy link

Currently there is a flaw with the draught blocking system in PvP and PvE combat. You can't drink them during the fight but you're able to drink them before the fight and keep the potion effect during the fight.
A solution would be to remove all potion effects at the start of the fight but that wouldn't be good as the potion effects might come from another source then draughts.

So the solution which I propose is to keep track which draught a player drank and how long it's potion effects are going to last for. When in combat it would check if the player has potion effects and if so if their end time and type correspond with the effect from the draughts. If it matches you could remove the potion effect from that player (and maybe give it back once they are out of combat).

This probably still has a few flaws but I think it would be better then the current system.

@CraftedMods CraftedMods added improvement For improvements regarding existing features medium priority For something with medium priority labels Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement For improvements regarding existing features medium priority For something with medium priority
Projects
None yet
Development

No branches or pull requests

2 participants