Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnPvP compatibility event. #338

Closed
DwarfyAssassin opened this issue Feb 10, 2019 · 1 comment
Closed

OnPvP compatibility event. #338

DwarfyAssassin opened this issue Feb 10, 2019 · 1 comment
Assignees
@VinyarionHyarmendacil
Labels
cleanup For refactoring and restructuring things compatibility Improve the interaction with other things medium priority For something with medium priority
Milestone
2.0.0-BETA.3

Comments

@DwarfyAssassin
Copy link

This would be a new compatibility event which would trigger when a Player attacks another Player.
This event could block/disable that attack from happening.
@DwarfyAssassin
Copy link
Author

#337 Malvegil already mentioned it there.

@CraftedMods CraftedMods mentioned this issue Feb 10, 2019
Open
@CraftedMods CraftedMods reopened this Feb 10, 2019
@CraftedMods CraftedMods added cleanup For refactoring and restructuring things compatibility Improve the interaction with other things medium priority For something with medium priority labels Feb 10, 2019
@CraftedMods CraftedMods added this to the 2.0.0-BETA.2 milestone Feb 10, 2019
@VinyarionHyarmendacil VinyarionHyarmendacil self-assigned this Jul 29, 2019
VinyarionHyarmendacil added a commit to VinyarionHyarmendacil/pvp-mode that referenced this issue Jul 29, 2019
@VinyarionHyarmendacil
Added an OnPvP compatability event
f9c50aa 
See Issue Lembas-Modding-Team#338: Lembas-Modding-Team#338
Merged
VinyarionHyarmendacil added a commit that referenced this issue Jul 31, 2019
@VinyarionHyarmendacil @mahtaran
Added an OnPvP compatability event (#356)
cccc19c 
* Added an OnPvP compatability event

See Issue #338: #338

* Fixed duplicate LivingAttackEvents

Alleviate the Forge bug causing duplicate posts of the LivingAttackEvent. Forge posts this event twice, once in EntityPlayer, and once in EntityLivingBase, so this tells if an EntityPlayer got hurt but the event was posted as an EntityLivingBase, then immediately returns, so nothing important gets run twice.

* Review 1: Added an OnPvP compatability event

* Improved pvpadmin command

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Review 2: Added an OnPvP compatability event

Co-Authored-By: Mahtaran <mahtaran@amuzil.com>
CraftedMods pushed a commit that referenced this issue Aug 26, 2019
@VinyarionHyarmendacil @mahtaran @CraftedMods
Added an OnPvP compatability event (#356)
1bd1f48 
* Added an OnPvP compatability event

See Issue #338:
#338

* Fixed duplicate LivingAttackEvents

Alleviate the Forge bug causing duplicate posts of the
LivingAttackEvent. Forge posts this event twice, once in EntityPlayer,
and once in EntityLivingBase, so this tells if an EntityPlayer got hurt
but the event was posted as an EntityLivingBase, then immediately
returns, so nothing important gets run twice.

* Review 1: Added an OnPvP compatability event

* Improved pvpadmin command

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Review 2: Added an OnPvP compatability event

Co-Authored-By: Mahtaran <mahtaran@amuzil.com>

Update src/main/java/pvpmode/api/server/compatibility/events/OnPvPEvent.java

Co-Authored-By: Mahtaran <luka.leer@gmail.com>
CraftedMods pushed a commit that referenced this issue Aug 26, 2019
@VinyarionHyarmendacil @mahtaran @CraftedMods
Added an OnPvP compatability event (#356)
314b68b 
* Added an OnPvP compatability event

See Issue #338:
#338

* Fixed duplicate LivingAttackEvents

Alleviate the Forge bug causing duplicate posts of the
LivingAttackEvent. Forge posts this event twice, once in EntityPlayer,
and once in EntityLivingBase, so this tells if an EntityPlayer got hurt
but the event was posted as an EntityLivingBase, then immediately
returns, so nothing important gets run twice.

* Review 1: Added an OnPvP compatability event

* Improved pvpadmin command

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Review 2: Added an OnPvP compatability event

Co-Authored-By: Mahtaran <mahtaran@amuzil.com>

Update src/main/java/pvpmode/api/server/compatibility/events/OnPvPEvent.java

Co-Authored-By: Mahtaran <luka.leer@gmail.com>
CraftedMods pushed a commit that referenced this issue Aug 26, 2019
@VinyarionHyarmendacil @mahtaran @CraftedMods
Added an OnPvP compatability event (#356)
8787a62 
* Added an OnPvP compatability event

See Issue #338:
#338

* Fixed duplicate LivingAttackEvents

Alleviate the Forge bug causing duplicate posts of the
LivingAttackEvent. Forge posts this event twice, once in EntityPlayer,
and once in EntityLivingBase, so this tells if an EntityPlayer got hurt
but the event was posted as an EntityLivingBase, then immediately
returns, so nothing important gets run twice.

* Review 1: Added an OnPvP compatability event

* Improved pvpadmin command

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Review 2: Added an OnPvP compatability event

Co-Authored-By: Mahtaran <mahtaran@amuzil.com>

Update src/main/java/pvpmode/api/server/compatibility/events/OnPvPEvent.java

Co-Authored-By: Mahtaran <luka.leer@gmail.com>
VinyarionHyarmendacil added a commit that referenced this issue Dec 16, 2019
@VinyarionHyarmendacil
Development (#365)
0d54c22 
* Renamed the faction placeholders HARAD and RHUN

Fixes a warning because the faction RHUN exists too.

* Added support for pledging specifiers

* Updated to v35.2 of the LOTR Mod

* Fixed a crash in singleplayer

* Added an OnPvP compatability event

See Issue #338: #338

* Fixed duplicate LivingAttackEvents

Alleviate the Forge bug causing duplicate posts of the LivingAttackEvent. Forge posts this event twice, once in EntityPlayer, and once in EntityLivingBase, so this tells if an EntityPlayer got hurt but the event was posted as an EntityLivingBase, then immediately returns, so nothing important gets run twice.

* Review 1: Added an OnPvP compatability event

* Improved pvpadmin command

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Review 2: Added an OnPvP compatability event

Co-Authored-By: Mahtaran <mahtaran@amuzil.com>

* Revert "Improved pvpadmin command"

This reverts commit f69c7c9.

* Added an OnPvP compatability event (#356)

* Added an OnPvP compatability event

See Issue #338: #338

* Fixed duplicate LivingAttackEvents

Alleviate the Forge bug causing duplicate posts of the LivingAttackEvent. Forge posts this event twice, once in EntityPlayer, and once in EntityLivingBase, so this tells if an EntityPlayer got hurt but the event was posted as an EntityLivingBase, then immediately returns, so nothing important gets run twice.

* Review 1: Added an OnPvP compatability event

* Improved pvpadmin command

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Review 2: Added an OnPvP compatability event

Co-Authored-By: Mahtaran <mahtaran@amuzil.com>

* Improved pvpadmin command, again

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Added togglable ability to poison drinks

See Issue #333

* Revert "Added togglable ability to poison drinks"

This reverts commit 510ebdd.

* Update src/main/java/pvpmode/internal/server/command/PvPCommandAdmin.java

Co-Authored-By: Mahtaran <mahtaran@amuzil.com>

* Update CHANGELOG.md

* Update ServerCommandConstants.java

* Fixed whitespace and incorrect conflict resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinyarionHyarmendacil VinyarionHyarmendacil

Labels
cleanup For refactoring and restructuring things compatibility Improve the interaction with other things medium priority For something with medium priority
Projects
None yet
Milestone
2.0.0-BETA.3
Development

No branches or pull requests
3 participants
@CraftedMods @VinyarionHyarmendacil @DwarfyAssassin