Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle ability to poison drinks #333

Open
AlteOgre opened this issue Jan 29, 2019 · 3 comments
Open

Toggle ability to poison drinks #333

AlteOgre opened this issue Jan 29, 2019 · 3 comments
Assignees
@VinyarionHyarmendacil
Labels
compatibility Improve the interaction with other things lotr Things related to the LOTR Mod medium priority For something with medium priority new feature For new features
Milestone
2.0.0-BETA.3

Comments

@AlteOgre
Copy link
Collaborator

AlteOgre commented Jan 29, 2019 •
edited
Loading

In the LOTRmod, players have the ability to poison drinks without others being aware of this. Drinkng a poisoned drink leads to instant 'death' and can therefore be considered 'indirect PvP'. The default methods for the PvP Mode mod (or server rules) to control the ahility to launch a PvP attack on players are not applicable / effective to this PvP option. This leaves us with only one rigorous option if we wish to eupport server owners to better control this ability: offer them a switch in the config that allows them to completely disable the feature.
Alternatively, if possible at all, blocking the ability to poison drinks in dependence of PvP Mode and/or LOTRmod biome and alignment, may be considered. Such options could be addressed in dedicated issues.

Implementation in v2.0.0-BETA seems highly desirable, possibly in one of the pre-releases.
@AlteOgre AlteOgre added compatibility Improve the interaction with other things new feature For new features medium priority For something with medium priority lotr Things related to the LOTR Mod labels Jan 29, 2019
@AlteOgre AlteOgre changed the title Toggle ahility to poison drinks Toggle ability to poison drinks Jan 29, 2019
@CraftedMods CraftedMods added this to the 2.0.0-BETA.2 milestone Jan 29, 2019
@CraftedMods
Copy link
Member

CraftedMods commented Feb 2, 2019 •
edited
Loading

I would suggest to add a configuration option which allows it to count the poisoned drinks as PvP, so the poison doesn't work if the PvP Mode is off for both players. I would suggest to disable that feature by default. Making that biome or alignment dependent seems weird to me...

@VinyarionHyarmendacil VinyarionHyarmendacil self-assigned this Jul 31, 2019
@VinyarionHyarmendacil
Copy link
Member

What if there was a configurable option for players to be unable to be poisoned by their own drinks? Such a system could be changed to permissions-based when that becomes available.

@CraftedMods
Copy link
Member

Sounds reasonable. So I suggest two configuration options for the LOTR compatibility module:

  • Poisoned drinks mode (0 to disable them, 1 to make them PvP Mode Mod dependent, 2 for the default behaviour)
  • Can poisoned drinks poison owner (true or false)

VinyarionHyarmendacil added a commit to VinyarionHyarmendacil/pvp-mode that referenced this issue Aug 5, 2019
@VinyarionHyarmendacil
Added togglable ability to poison drinks
510ebdd 
See Issue Lembas-Modding-Team#333
VinyarionHyarmendacil added a commit that referenced this issue Dec 16, 2019
@VinyarionHyarmendacil
Development (#365)
0d54c22 
* Renamed the faction placeholders HARAD and RHUN

Fixes a warning because the faction RHUN exists too.

* Added support for pledging specifiers

* Updated to v35.2 of the LOTR Mod

* Fixed a crash in singleplayer

* Added an OnPvP compatability event

See Issue #338: #338

* Fixed duplicate LivingAttackEvents

Alleviate the Forge bug causing duplicate posts of the LivingAttackEvent. Forge posts this event twice, once in EntityPlayer, and once in EntityLivingBase, so this tells if an EntityPlayer got hurt but the event was posted as an EntityLivingBase, then immediately returns, so nothing important gets run twice.

* Review 1: Added an OnPvP compatability event

* Improved pvpadmin command

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Review 2: Added an OnPvP compatability event

Co-Authored-By: Mahtaran <[email protected]>

* Revert "Improved pvpadmin command"

This reverts commit f69c7c9.

* Added an OnPvP compatability event (#356)

* Added an OnPvP compatability event

See Issue #338: #338

* Fixed duplicate LivingAttackEvents

Alleviate the Forge bug causing duplicate posts of the LivingAttackEvent. Forge posts this event twice, once in EntityPlayer, and once in EntityLivingBase, so this tells if an EntityPlayer got hurt but the event was posted as an EntityLivingBase, then immediately returns, so nothing important gets run twice.

* Review 1: Added an OnPvP compatability event

* Improved pvpadmin command

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Review 2: Added an OnPvP compatability event

Co-Authored-By: Mahtaran <[email protected]>

* Improved pvpadmin command, again

`pvpadmin resetCooldown <player>`
and
`pvpadmin spy <player> [on|off]`

* Added togglable ability to poison drinks

See Issue #333

* Revert "Added togglable ability to poison drinks"

This reverts commit 510ebdd.

* Update src/main/java/pvpmode/internal/server/command/PvPCommandAdmin.java

Co-Authored-By: Mahtaran <[email protected]>

* Update CHANGELOG.md

* Update ServerCommandConstants.java

* Fixed whitespace and incorrect conflict resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinyarionHyarmendacil VinyarionHyarmendacil

Labels
compatibility Improve the interaction with other things lotr Things related to the LOTR Mod medium priority For something with medium priority new feature For new features
Projects
None yet
Milestone
2.0.0-BETA.3
Development

No branches or pull requests
3 participants
@AlteOgre @CraftedMods @VinyarionHyarmendacil