Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for other dimensions than DIM 100 #249

Open
AlteOgre opened this issue Sep 6, 2018 · 4 comments
Open

Settings for other dimensions than DIM 100 #249

AlteOgre opened this issue Sep 6, 2018 · 4 comments
Labels
medium priority For something with medium priority new feature For new features
Milestone

Comments

@AlteOgre
Copy link
Collaborator

AlteOgre commented Sep 6, 2018

I suspect we have overseen this one. For now, I believe the global PvP Mode condition is valid in all worlds.
It would be helpful and sufficient imo if servers could have either of three (server determined) options in other worlds (Overworld, Nether, End and Utumno (DIM 101, biome id 0)) for the players PvP Modes:

  • Free to choose: PvP Toggling enabled.
  • Get PvP Mode forced ON.
  • Get PvP Mode forced OFF.
    Timers and other variables are valid in all worlds.

Obviously, this would require configuration entries. I think a separate file would be fitting, in line with latest insights.

This could also address compatibility with other mods that add dimensions to the game, like Aether and Twilight Forest. It may be wisest to address those in separate issues, so we can tackle those later, after this one.

@AlteOgre AlteOgre added new feature For new features medium priority For something with medium priority labels Sep 6, 2018
@AlteOgre AlteOgre changed the title Forced override setting for other dimensions than DIM 100 Settings for other dimensions than DIM 100 Sep 6, 2018
@CraftedMods
Copy link
Member

Required a major version, probably.

@DwarfyAssassin
Copy link

Would it also be possible to make specific regions from world guard have set rules. Like in the world guard called "arena" pvp would be forced on.
Maybe you could also add more config options for where partial inventory drop is active. For example it would be disabled in the overworld and enabled in middle earth.

@AlteOgre
Copy link
Collaborator Author

Yes, Worldguard compatibility can be considered a planned extension of this feature.

@DwarfyAssassin
Copy link

So will feature be for v2 or lembas?

@CraftedMods CraftedMods added this to the 2.0.0-BETA.2 milestone Jan 18, 2019
@CraftedMods CraftedMods modified the milestones: 2.0.0-BETA.2, 2.0.0-BETA.3 Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority For something with medium priority new feature For new features
Projects
None yet
Development

No branches or pull requests

3 participants