Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that hired units can be attacked if the owner isn't logged in #113

Open
CraftedMods opened this issue Jun 21, 2018 · 0 comments
Open

Fix that hired units can be attacked if the owner isn't logged in #113

CraftedMods opened this issue Jun 21, 2018 · 0 comments
Assignees
@CraftedMods
Labels
bug Something isn't working as expected compatibility Improve the interaction with other things high priority For something with high priority
Milestone
2.0.0-BETA.3

Comments

@CraftedMods
Copy link
Member

CraftedMods commented Jun 21, 2018 •
edited
Loading

That's because MC then cannot obtain EntityPlayer instances for them. So the data needs to be accessed independent of the player entities. Make a general storage. We need code to transfer the old data to the new storage - add a message to the logs, if that's the case. The old data will be deleted after a successful transfer (if they're present it's an indicator that the data have to be ported).
@CraftedMods CraftedMods added bug Something isn't working as expected compatibility Improve the interaction with other things high priority For something with high priority breaking change For things that break the current API labels Jun 21, 2018
@CraftedMods CraftedMods added this to the 2.0.0-BETA milestone Jun 21, 2018
@CraftedMods CraftedMods removed the breaking change For things that break the current API label Jun 21, 2018
@CraftedMods CraftedMods changed the title Fix that hired units can attack each other of on of the owners isn't logged in Fix that hired units can be attacked of the owner isn't logged in Jun 21, 2018
@CraftedMods CraftedMods mentioned this issue Jun 21, 2018
Closed
@CraftedMods CraftedMods changed the title Fix that hired units can be attacked of the owner isn't logged in Fix that hired units can be attacked if the owner isn't logged in Jun 22, 2018
@CraftedMods CraftedMods modified the milestones: 2.0.0-BETA.1, 2.0.0-BETA.2 Sep 8, 2018
@CraftedMods CraftedMods self-assigned this Jul 2, 2019
@CraftedMods CraftedMods mentioned this issue Dec 13, 2019
Merged
CraftedMods added a commit to CraftedMods/pvp-mode that referenced this issue Mar 27, 2020
@CraftedMods
Fixed Lembas-Modding-Team#113
45a31bc
@CraftedMods CraftedMods mentioned this issue Mar 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CraftedMods CraftedMods

Labels
bug Something isn't working as expected compatibility Improve the interaction with other things high priority For something with high priority
Projects
None yet
Milestone
2.0.0-BETA.3
Development

No branches or pull requests
1 participant
@CraftedMods