Fixing #38 #56
Merged
Fixing #38 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpascal-ledger
force-pushed
the
bug/#38
branch
3 times, most recently
from
315aff5 to
e043f78
Compare
lpascal-ledger
force-pushed
the
develop
branch
from
a35b7c8 to
6975dc9
Compare
lpascal-ledger
force-pushed
the
bug/#38
branch
from
e043f78 to
270b5e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #38
Fix #34
Previous behavior:
Between every character sent to the host, the app was inserting an empty report (
0x0000000000000000).New behavior
Between every character sent to the host, the app inserts an empty report (
0x0000000000000000) if the previous character was not using the SHIFT key ; else it sends a CAPS report (0x0200000000000000).Apparently some applications get confused if the character is capitalized but the following intermediate USB packet is not, and choose to render the first character as capitalized or not randomly.
That also impacts special characters triggered with the SHIFT key, for instance:
Qwerty
7/&]/}//?Azerty
$/£è/7://