Critical lags due to "Protections.MobSpawning: true"

[MrClean1337]

Hello,

AFKPlus is causing huge lag if players are flying / running around in a farmworld.

This event causes huge lag:

AFKPlus/src/main/java/net/lapismc/afkplus/AFKPlusListeners.java

Lines 230 to 240 in 78b67cd

	@EventHandler
	public void onNaturalMonsterSpawn(CreatureSpawnEvent e) {
	if (!plugin.getConfig().getBoolean("Protections.MobSpawning"))
	return;
	//Return if it's not a monster or if it isn't natural
	if (!(e.getEntity() instanceof Monster) || !e.getSpawnReason().equals(CreatureSpawnEvent.SpawnReason.NATURAL))
	return;
	boolean shouldSpawn = spawnManager.shouldNaturalSpawn(e.getLocation());
	if (!shouldSpawn)
	e.setCancelled(true);
	}

You can see this at my timings:
https://timings.aikar.co/dev/?id=8686e105aec34126a0175c0c93f17930#timings

I updated to git-Paper-513 (MC: 1.19.4) and to AFKPlus to 3.4.1 and then for some reason the server began to lag hugely.
If I switched the Protections.MobSpawning to false, the lag is gone.

[Dart2112]

This is a known issue. All the plugin can do is cancel mob spawns, but when it does that the server just tries to spawn them again. This results in the plugin essentially fighting the server to stop it from spawning mobs. I'm keeping an eye out for a solution, but for now it's not an option that can be used on servers without the horsepower to keep up.

[Dart2112]

Attached is a version that could be a little better, it's potentially more efficient at detecting if a mob should spawn or not. But the issue of the server continually trying to spawn the mobs will still exist
AFKPlus-Beta.zip