Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support Android 12 #11

Open
pdecostervgls opened this issue Jan 12, 2022 · 5 comments
Open

Please support Android 12 #11

pdecostervgls opened this issue Jan 12, 2022 · 5 comments

Comments

@pdecostervgls
Copy link

pdecostervgls commented Jan 12, 2022

Is your feature request related to a problem? Please describe.
Yes, the latest android release requires a PendingIntent to provide a Mutable or Immutable flag, which has been added by the Nordic Library (NordicSemiconductor/Android-DFU-Library@050f788) 3 months ago. Without this change the application crashes.

Describe the solution you'd like
Build a new NuGet package taking into account the Nordic Library with Android 12 support

Describe alternatives you've considered
I tried building a NuGet myself, but the build.sh crashed on not being able to find a directory after the msbuild command.

@haoyuant
Copy link

Any update on this?

@haoyuant
Copy link

Here is the error log:

### MSBUILD ###

msbuild_parameters =  -nologo -verbosity:quiet -t:Rebuild -restore:True -p:Configuration=Release

/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error : DirectoryNotFoundException: Could not find a part of the path "/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/obj/Release/xamarin.ios10/GitVersionInformation.g.cs". [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.Boolean anonymous, System.IO.FileOptions options) [0x00164] in <92218043474744ea9d64d27064c35dcb>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.IO.FileOptions options) [0x00000] in <92218043474744ea9d64d27064c35dcb>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at (wrapper remoting-invoke-with-check) System.IO.FileStream..ctor(string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare,int,System.IO.FileOptions) [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at System.IO.StreamWriter..ctor (System.String path, System.Boolean append, System.Text.Encoding encoding, System.Int32 bufferSize) [0x00055] in <92218043474744ea9d64d27064c35dcb>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at System.IO.StreamWriter..ctor (System.String path, System.Boolean append, System.Text.Encoding encoding) [0x00000] in <92218043474744ea9d64d27064c35dcb>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at (wrapper remoting-invoke-with-check) System.IO.StreamWriter..ctor(string,bool,System.Text.Encoding) [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at System.IO.File.WriteAllText (System.String path, System.String contents, System.Text.Encoding encoding) [0x00034] in <92218043474744ea9d64d27064c35dcb>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at GitVersion.FileSystem.WriteAllText (System.String file, System.String fileContents, System.Text.Encoding encoding) [0x00000] in <995304a82d99401bb6f71b9add25a247>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at GitVersion.FileSystem.WriteAllText (System.String file, System.String fileContents) [0x00010] in <995304a82d99401bb6f71b9add25a247>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at GitVersion.VersionConverters.GitVersionInfo.GitVersionInfoGenerator.Execute (GitVersion.OutputVariables.VersionVariables variables, GitVersion.VersionConverters.GitVersionInfo.GitVersionInfoContext context) [0x00099] in <995304a82d99401bb6f71b9add25a247>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at GitVersion.GitVersionOutputTool.GenerateGitVersionInformation (GitVersion.OutputVariables.VersionVariables variables, GitVersion.FileWriteInfo fileWriteInfo) [0x00031] in <995304a82d99401bb6f71b9add25a247>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at GitVersion.MsBuild.GitVersionTaskExecutor.GenerateGitVersionInformation (GitVersion.MsBuild.Tasks.GenerateGitVersionInformation task) [0x00062] in <ebc5e9e0dba44146843bb460770743f5>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at GitVersion.MsBuild.GitVersionTasks+<>c__DisplayClass2_0.<GenerateGitVersionInformation>b__0 (GitVersion.MsBuild.IGitVersionTaskExecutor executor) [0x00000] in <ebc5e9e0dba44146843bb460770743f5>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :   at GitVersion.MsBuild.GitVersionTasks.ExecuteGitVersionTask[T] (T task, System.Action`1[T] action) [0x0001d] in <ebc5e9e0dba44146843bb460770743f5>:0  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]
/Users/tomtekt/.nuget/packages/gitversion.msbuild/5.6.11/tools/GitVersion.MsBuild.targets(110,9): error :  [/Users/tomtekt/Projects/Laerdal.Dfu/Laerdal.Dfu/Laerdal.Dfu.csproj]

@pdecostervgls
Copy link
Author

pdecostervgls commented Jan 14, 2022

@haoyuant It might be a good idea to create a separate issue for this, because it is not related to Android 12 support. Even though i'm getting the same error.

@framinosona
Copy link
Member

@haoyuant : For info, I've had this bug on builds too, removing the -t:Rebuild fixed it ... not 100% sure of the root cause and didn't have more time to investigate
@pdecostervgls : I've updated the library in v0.7.0, Let me know if it fixes your issue.

@gnnsekhar
Copy link

Why do we need Location permission for the firmware update? any specific reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants