Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking LMFDB for broken external links #6225

Open
jenpaulhus opened this issue Nov 3, 2024 · 2 comments
Open

Checking LMFDB for broken external links #6225

jenpaulhus opened this issue Nov 3, 2024 · 2 comments
Labels
feature request Feature request knowls Displaying or editing knowls (not content related)
Milestone

Comments

@jenpaulhus
Copy link
Contributor

Today someone noted on a bug report form that we had a broken external link for a paper referenced in a knowl. I fixed the particular example (an msri.org file that is now located at slmath.org) but it would be nice to have a system that occasionally checks the lmfdb for broken external links.

@jenpaulhus jenpaulhus added the feature request Feature request label Nov 3, 2024
@AndrewVSutherland AndrewVSutherland added the knowls Displaying or editing knowls (not content related) label Nov 3, 2024
@edgarcosta
Copy link
Member

We already have a tool for that (except, it never went through the knowls), but at some point, we decided to disable them from the GitHub workflow tests, as many of the external links were not reliable, so we had too many false test failures because of these.

https://github.com/LMFDB/lmfdb/blob/main/lmfdb/tests/__init__.py#L60-L75

@AndrewVSutherland
Copy link
Member

I don't think we want to do this as part of our GitHub/CI workflow, but I do think it would be useful to have a test we could run on demand that would also cover knowls.

@roed314 roed314 added this to the v1.4 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request knowls Displaying or editing knowls (not content related)
Projects
None yet
Development

No branches or pull requests

4 participants