From bc033eb60d1a9b39988d07c2abb59655683fb107 Mon Sep 17 00:00:00 2001 From: Kenneth Weiss Date: Thu, 19 Jan 2023 15:05:27 -0800 Subject: [PATCH] Bugfix for RAJA's optional RAJA::roctx dependency When we specify that `core` depends on `RAJA` in `blt_add_library`, it should transitively depend on RAJA's dependencies. However, the `RAJA::roctx` dependency was not being properly propagated. The latter is present when RAJA is configured with `RAJA_ENABLE_ROCTX`. --- src/axom/core/CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/axom/core/CMakeLists.txt b/src/axom/core/CMakeLists.txt index 9172cdec31..25f1007ead 100644 --- a/src/axom/core/CMakeLists.txt +++ b/src/axom/core/CMakeLists.txt @@ -103,6 +103,12 @@ blt_list_append( TO core_depends ELEMENTS blt::hip_runtime IF ENABLE_HIP) blt_list_append( TO core_depends ELEMENTS openmp IF ENABLE_OPENMP) blt_list_append( TO core_depends ELEMENTS mpi IF ENABLE_MPI ) +# HACK: RAJA's dependencies are not getting added to core due to a bug in +# dependency propagation in blt_register_library. Explicitly add it in the short term. +if(TARGET RAJA::roctx) + list(APPEND core_depends RAJA::roctx) +endif() + #------------------------------------------------------------------------------ # Make/Install the library #------------------------------------------------------------------------------