Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose config via authorino cr to enable the deployment of envoy sidecar to authorino #239

Open
laurafitzgerald opened this issue Jan 31, 2025 · 3 comments
Assignees
Labels
kind/enhancement New feature or request

Comments

@laurafitzgerald
Copy link

Is your feature request related to a problem? Please describe.
Expose configuration in the authorino cr which allows a user to ask for the addition of the following lable to the authorino deployment "sidecar.istio.io/inject":"true"

Describe the solution you'd like
A value exposed in the cr which the operator responds to by applying the label.
The label should be applied if the value is set to true
The label should be removed if the value isn't present or set to false.

Additional context
This work forms part of a set of issues to enable the automatic configuration of https://github.com/Kuadrant/kuadrant-operator/blob/a1ca1d0ee2ca7dac79ad921b0ff30ded2c986612/doc/install/mtls-configuration.md#configure-mtls-between-the-gateway-and-kuadrant-components

@laurafitzgerald laurafitzgerald self-assigned this Jan 31, 2025
@laurafitzgerald laurafitzgerald added the kind/enhancement New feature or request label Jan 31, 2025
@laurafitzgerald
Copy link
Author

Copied comment Work being done in authorino-operator #236

@laurafitzgerald laurafitzgerald moved this to Todo in Kuadrant Jan 31, 2025
@laurafitzgerald laurafitzgerald moved this from Todo to In Progress in Kuadrant Jan 31, 2025
@guicassolato
Copy link
Collaborator

Instead of something specific to sidecar injection, probably what we want here is the propagation of labels added to the Authorino CR all the way down to the pods that are linked to the Deployment object managed by the operator in relation to that CR, i.e. add the labels to the deployment template. IOW, #236.

@laurafitzgerald
Copy link
Author

Thanks @guicassolato @eguzki had pointed to that work in another ticket and I've linked it above. It definitely makes sense to go that route rather than adding a separate method for this particular piece of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants