Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack horizion material themes invalid icon content generated via pyScss 1.3.5 #375

Open
cygmris opened this issue Sep 1, 2018 · 0 comments
Open

openstack horizion material themes invalid icon content generated via pyScss 1.3.5 #375

cygmris opened this issue Sep 1, 2018 · 0 comments

Comments

@cygmris
Copy link

cygmris commented Sep 1, 2018 •
edited
Loading

Under Ubuntu:Bionic with latest packages installed (including apt installed version of pyScss 1.3.5), The icons are being compiled wrong with content 'xf101' instead of '\f101'.

After downgrade pyScss to 1.3.4, icon content displayed normally.

Check:

and static/horizon/lib/mdi/scss/_icons.scss

@function char($character-code) {
    @if function-exists("selector-append") {
        @return unquote("\"\\#{$character-code}\"");
    }
    @if "\\#{'x'}" == "\\x" {
        @return str-slice("\x", 1, 1) + $character-code;
    } @else {
        @return #{"\"\\"}#{$character-code + "\""};
    }
}

@function mdi($name) {
    @return char(nth($hexes, index($names, $name)));
}

@for $i from 1 through length($hexes) {
    .#{$mdi-css-prefix}-#{nth($names, $i)}:before {
        content: char(nth($hexes, $i));
    }
}

hexes is string like 'f101 '.
wdoekes added a commit to ossobv/horizon that referenced this issue Oct 29, 2019
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
2ce3522 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
wdoekes added a commit to ossobv/horizon that referenced this issue Oct 29, 2019
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
34ed01e 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
wdoekes added a commit to ossobv/horizon that referenced this issue Oct 29, 2019
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
578ef44 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
wdoekes added a commit to ossobv/horizon that referenced this issue Nov 1, 2019
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
b247714 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
wdoekes added a commit to ossobv/horizon that referenced this issue Mar 10, 2020
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
2e5bcac 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
wdoekes added a commit to ossobv/horizon that referenced this issue Mar 10, 2020
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
c704b60 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
wdoekes added a commit to ossobv/horizon that referenced this issue Sep 25, 2020
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
1b7c353 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
wdoekes added a commit to ossobv/horizon that referenced this issue Sep 25, 2020
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
7b05897 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
wdoekes added a commit to ossobv/horizon that referenced this issue Nov 8, 2022
@wdoekes
static: Fix inclusion of XStatic-mdi (Material Design Icons)
4c21721 
Fixes so pyScss 1.3.5 works.

And corrects the path, from:

     /static/horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

To:

     /static//horizon/lib/mdi/fonts/materialdesignicons-webfont.woff2?v=1.6.50

This matters for some file servers, like the uwsgi router_static.

Now we don't get all of these errors anymore:

    ERROR scss.ast Function not found: twbs-font-path:1
    ERROR scss.ast Function not found: twbs-font-path:1
    (..repeat..)
    ERROR scss.ast Function not found: function-exists:1
    ERROR scss.ast Function not found: function-exists:1
    (..repeat..)

But just one complaint about the twbs-font-path.

See: Kronuz/pyScss#375
See: https://bugs.launchpad.net/horizon/+bug/1771559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cygmris