New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

narrow literal types #717

Open

KotlinIsland opened this issue Jul 23, 2024 · 1 comment · May be fixed by #812 or #852

Labels

Owner

KotlinIsland commented Jul 23, 2024 •

edited

Loading

a = "is this a joke"
reveal_type(a)  # str

b: str
assert b == "is this a joke"
reveal_type(b)  # str

KotlinIsland added the feature label

Collaborator

DetachHead commented Jul 23, 2024

it should also narrow in cases like this:

from typing import Literal

value: str

assert value == "asdf" # not sure about this because __eq__ can be overridden
assert value is "asdf" # but this one should definitely work

foo: Literal["asdf"] = value # error: Incompatible types in assignment (expression has type "str", variable has type "Literal['asdf']")

KotlinIsland added the p-1 label

This was referenced Nov 6, 2024

Open

Type functions part 1 #812

Draft

KotlinIsland linked a pull request

that will close this issue

narrow to literal value #852

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment