-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request-transformer rename
is not preserving renamed header casing
#11579
Comments
Thanks for reporting this. This might be a breaking change to make it case-sensitive but it looks alright: people who care about the case will write it correctly in the configuration. We will be discussing this. |
Created internal ticket KAG-2599 |
This issue is marked as stale because it has been open for 14 days with no activity. |
Hi @hanshuebner ,Has this issue been resolved? I seem to be encountering the same problem. When I rename the header, it doesn't seem to work. But the interesting thing is that when I add a new header it works。 Plugin configuration: log:
Looking forward to your reply, thank you. |
Hi @zyiqian, I've followed up internally to see whether we can get this fixed. |
We do not plan on addressing this issue due to widespread downstream impact, however, you should be able to use kong.service.request.set_headers and https://docs.konghq.com/hub/kong-inc/post-function/ to achieve the same goal. |
Is there an existing issue for this?
Kong version (
$ kong version
)3.4.0
Current Behavior
Consider request-transformer configuration:
When renaming the header, the new value sent upstream is
X-Bar-Qixqux
Expected Behavior
The expected header sent upstream is
X-BAR-QixQux
(case sensitive).Now, according to HTTP RFC, the plugin behavior is OK; however, we have run into some implementation of upstream services that require strict http header casing, and it would be better if Kong preserved the renamed header casing.
This is similar to Issue #4504
Steps To Reproduce
Set up request-transformer plugin with the above config, execute request with inbound header that is renamed, observe the casing of the header sent to upstream.
Anything else?
No response
The text was updated successfully, but these errors were encountered: