[ARRR] add unconfirmed change notes to unspent

[borngraced]

when a transaction with a change output is created, the change notes are not being properly added to the list of unspent outputs which may results in inaccurate tracking ofunconfirmed transactions.

[shamardy]

@cipig @KomodoPlatform/qa please check if the issue is resolved in latest dev and close this issue if that's the case

[cipig]

i started a ARRR swap, but it failed on takerfee

      {
         "event" : {
            "data" : {
               "error" : "taker_swap:1320] mm2src/coins/z_coin.rs:1233] z_coin:500] z_coin:483] GenTxError(SaveChangeNotesError(\"storage:206] NOT NULL constraint failed: received_notes.nf\"))"
            },
            "type" : "TakerFeeSendFailed"
         },
         "timestamp" : 1738083354404
      },

[cipig]

btw, is this #1572 the same?

[borngraced]

i started a ARRR swap, but it failed on takerfee

      {
         "event" : {
            "data" : {
               "error" : "taker_swap:1320] mm2src/coins/z_coin.rs:1233] z_coin:500] z_coin:483] GenTxError(SaveChangeNotesError(\"storage:206] NOT NULL constraint failed: received_notes.nf\"))"
            },
            "type" : "TakerFeeSendFailed"
         },
         "timestamp" : 1738083354404
      },

not expected..I'll look more into it this week

btw, is this #1572 the same?

upd: @cipig the issue is indeed very much related to this after taking another look at and I think the fix in PR #2331 also covers the issue here...
user balance will only now show amount that can be spent excluding unconfirmed change outputs and generating tx should wait for previous tx confirmations when and if needed to generate new tx.

[cipig]

generating tx should wait for previous tx confirmations when and if needed to generate new tx

hmmm, but then it didn't worked, see #2331 (comment) ... swap failed because sending takerpayment (ARRR) failed... and i assume it failed because change from takerfee (that was meant to be used in takerpayment) was not confirmed by the time takerpayment was sent

[borngraced]

generating tx should wait for previous tx confirmations when and if needed to generate new tx

hmmm, but then it didn't worked, see #2331 (comment) ... swap failed because sending takerpayment (ARRR) failed... and i assume it failed because change from takerfee (that was meant to be used in takerpayment) was not confirmed by the time takerpayment was sent

@cipig I made a new commit in the PR f03b30e ..can you test again please

I also, I will be happy to have the log file.