Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Hot reload coins file #1964

Open
smk762 opened this issue Sep 8, 2023 · 1 comment
Open

[FR] Hot reload coins file #1964

smk762 opened this issue Sep 8, 2023 · 1 comment

Comments

@smk762
Copy link

smk762 commented Sep 8, 2023

There has been some ongoing discussion regarding the ability for users to update their coins file "on demand" when a newer version is available or when a critical infra update etc would otherwise require a new release of the app(s).

Related: https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/2035

The way the API currently works, app users would need to restart mm2 for any updated coins file to take effect. It would be better UX if an additional rpc like refresh_coin_data was available which could internally update the coins configuration without a restart.

This would also be useful for more quickly testing coins file variations, or being able to load from folder of snippets etc.

Something like

 {
    "mmrpc":"2.0",
    "userpass":"testpsw",
    "method":"refresh_coins_data",
    "params": {
      "path":"/path/to/coins"   # optional, defaults to 'coins' file in mm2 binary folder
    },
    "id":42
  }

One potential cases to consider how to best handle - what happens to coins which are activated but not present in the new file?

Is this rpc doable without disturbing the foundations?

@smk762
Copy link
Author

smk762 commented Sep 20, 2023

for bonus points, "path" could also be a url. ideally we could have a few coins_configs hosted, and people can use url to get them or path to use a local custom one. Instead of defining electrums etc in activation method params, it uses whats in the active coins file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant