You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The HTML file generated with the call logs may end up with calls that are not labelled properly. A call should be labelled as, e.g. "A voice call from ABC was missed", whereas many entries get labelled as "A voice call to ABC was".
Reason
The calls() function in android_handler.py deals with different call_results (starting at line 727). The issue is that there are more call_results than what the code deals with.
Specifically, the code deals with call_result 2, 3 and 5. However, there are call_result codes also of at least 0, 1, 4 and 7. Since there is no "else", you get the mislabelled entry of "A voice call to ABC was".
Solution
Add elif statements there for call_result 0, 1, 4, and 7 -- if it is known what any of those actually mean. Otherwise an "else" catch-all could also work.
From my own analysis comparing to the call log on my phone, it seems to me that at least some of the calls with call_result 0, 4 and 7 were calls that were cancelled by the user (in the case of the user initiating the call), and then for someone else calling in, the phone labelled them "missed". But I was just looking at it on my own, and those specific codes may mean other things as I'm not an expert on this.
The text was updated successfully, but these errors were encountered:
Describe the bug
The HTML file generated with the call logs may end up with calls that are not labelled properly. A call should be labelled as, e.g. "A voice call from ABC was missed", whereas many entries get labelled as "A voice call to ABC was".
Reason
The calls() function in android_handler.py deals with different call_results (starting at line 727). The issue is that there are more call_results than what the code deals with.
Specifically, the code deals with call_result 2, 3 and 5. However, there are call_result codes also of at least 0, 1, 4 and 7. Since there is no "else", you get the mislabelled entry of "A voice call to ABC was".
Solution
Add elif statements there for call_result 0, 1, 4, and 7 -- if it is known what any of those actually mean. Otherwise an "else" catch-all could also work.
From my own analysis comparing to the call log on my phone, it seems to me that at least some of the calls with call_result 0, 4 and 7 were calls that were cancelled by the user (in the case of the user initiating the call), and then for someone else calling in, the phone labelled them "missed". But I was just looking at it on my own, and those specific codes may mean other things as I'm not an expert on this.
The text was updated successfully, but these errors were encountered: