Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] call logs not recognized + workaround #117

Open
code-consensus opened this issue Sep 24, 2024 · 1 comment
Open

[BUG] call logs not recognized + workaround #117

code-consensus opened this issue Sep 24, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@code-consensus
Copy link

code-consensus commented Sep 24, 2024

  • WhatsApp version: at least v2.23.xx onward
  • OS: Android v14
  • Platform: n/a
  • Branch and version: 0.10.0

Describe the bug
The HTML file generated with the call logs may end up with calls that are not labelled properly. A call should be labelled as, e.g. "A voice call from ABC was missed", whereas many entries get labelled as "A voice call to ABC was".

Reason
The calls() function in android_handler.py deals with different call_results (starting at line 727). The issue is that there are more call_results than what the code deals with.

Specifically, the code deals with call_result 2, 3 and 5. However, there are call_result codes also of at least 0, 1, 4 and 7. Since there is no "else", you get the mislabelled entry of "A voice call to ABC was".

Solution
Add elif statements there for call_result 0, 1, 4, and 7 -- if it is known what any of those actually mean. Otherwise an "else" catch-all could also work.

From my own analysis comparing to the call log on my phone, it seems to me that at least some of the calls with call_result 0, 4 and 7 were calls that were cancelled by the user (in the case of the user initiating the call), and then for someone else calling in, the phone labelled them "missed". But I was just looking at it on my own, and those specific codes may mean other things as I'm not an expert on this.

@KnugiHK KnugiHK added the bug Something isn't working label Sep 24, 2024
@KnugiHK KnugiHK self-assigned this Sep 24, 2024
@KnugiHK
Copy link
Owner

KnugiHK commented Sep 24, 2024

Fixed in ffb6aef. For the call states 0, 4, and 7, they will need to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants