Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTNL PJK File Update #139

Closed
arcsump opened this issue Apr 27, 2022 Discussed in #138 · 4 comments
Closed

PTNL PJK File Update #139

arcsump opened this issue Apr 27, 2022 Discussed in #138 · 4 comments

Comments

@arcsump
Copy link

arcsump commented Apr 27, 2022

Discussed in #138

Originally posted by arcsump April 21, 2022
Hi @Knio ,
Thanks for the awesome library,

I needed to extend a proprietary class, wondering if it can be properly incorporated.
That would be great, many thanks again - I am not that well-versed so yeah pardon me.

Meanwhile, I modified tnl.py and added this snippet

class TNLPJK (TNL, DatetimeFix):
fields = (
('Empty', '_'),
('Sentence Type', 'type'),
('Timestamp', 'timestamp', timestamp),
("Datestamp", "datestamp", datestamp),
('Northing', 'northing'),
('Northing Direction', 'northing_dir'),
('Easting', 'easting'),
('Easting Direction', 'easting_dir'),
('GPS Quality', 'gps_quality'),
('Total number of satelites in use', 'num_sats'),
('DOP', 'dop'),
('Height of Antenna Phase Center, GHT or EHT', 'phase_center_height'),
)

@kamiccolo
Copy link
Contributor

Mhm. Weird, I remember making a PR some time ago: #75

Which seems... to get merged only partially. Will see what can I do about that.

@arcsump
Copy link
Author

arcsump commented Jan 26, 2024 via email

@kamiccolo
Copy link
Contributor

I believe this can be closed :) PR got merged: #75

Adding: TNLDG, TNLVGK and TNLPJK

@arcsump
Copy link
Author

arcsump commented Mar 13, 2024

Awesome! Many thanks for this!

@arcsump arcsump closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants