Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime SPIR-V VUIDs that could be validated standalone #2267

Open
Rua opened this issue Oct 31, 2023 · 3 comments
Open

Runtime SPIR-V VUIDs that could be validated standalone #2267

Rua opened this issue Oct 31, 2023 · 3 comments
Assignees

Comments

@Rua
Copy link
Contributor

Rua commented Oct 31, 2023

The Runtime SPIR-V section of the spec is supposed to contain things that can only be validated at runtime, because they rely on properties of the device, enabled features, or input data from the user. But the following VUIDs don't seem to rely on anything at runtime, they use only information that's known from the SPIR-V code. So they should probably be moved to the Standalone SPIR-V section.

@spencer-lunarg
Copy link

VUID-RuntimeSpirv-OpImageWrite-07112

You need to know the descriptor bound to it in order to match the VkFormat

@Rua
Copy link
Contributor Author

Rua commented Oct 31, 2023

You need to know the descriptor bound to it in order to match the VkFormat

If the format is specified in the shader itself, do you not know how many components it has?

@spencer-lunarg spencer-lunarg self-assigned this Nov 8, 2023
@gnl21
Copy link
Contributor

gnl21 commented Nov 8, 2023

You need to know the descriptor bound to it in order to match the VkFormat

If the format is specified in the shader itself, do you not know how many components it has?

Yes, the table referred to in the VU gives the VkFormat corresponding to the format used in the SPIR-V code. It's not a reference to the actual format of the descriptor in this case. The VU that matches with the actual descriptor format it, for example, VUID-vkCmdDraw-OpImageWrite-08795.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants