From 5fc266a7855fb6cefe8039c1c16ee9744c78a52b Mon Sep 17 00:00:00 2001 From: "atharva.dubey" Date: Fri, 1 Dec 2023 15:09:51 +0000 Subject: [PATCH 1/7] added imposed alignment requirements on the pointer passed to sycl::vec' load/store method --- adoc/chapters/programming_interface.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adoc/chapters/programming_interface.adoc b/adoc/chapters/programming_interface.adoc index 64520352..141eaa82 100644 --- a/adoc/chapters/programming_interface.adoc +++ b/adoc/chapters/programming_interface.adoc @@ -17218,7 +17218,7 @@ a@ template void load(size_t offset, multi_ptr ptr) ---- - a@ Loads the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#, into the components of this SYCL [code]#vec#. + a@ Loads the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#, into the components of this SYCL [code]#vec#. [code]#vec# must be aligned to the size of the data type of this SYCL vec. a@ [source] @@ -17226,7 +17226,7 @@ a@ template void store(size_t offset, multi_ptr ptr) const ---- - a@ Stores the components of this SYCL [code]#vec# into the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#. + a@ Stores the components of this SYCL [code]#vec# into the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#. [code]#vec# must be aligned to the size of the data type of this SYCL vec. a@ [source] From 0f0b02d5610e251477689ebcbe46940581b917f7 Mon Sep 17 00:00:00 2001 From: "atharva.dubey" Date: Thu, 14 Dec 2023 14:49:22 +0000 Subject: [PATCH 2/7] addressed review comments --- adoc/chapters/programming_interface.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adoc/chapters/programming_interface.adoc b/adoc/chapters/programming_interface.adoc index 141eaa82..51fd1f29 100644 --- a/adoc/chapters/programming_interface.adoc +++ b/adoc/chapters/programming_interface.adoc @@ -17218,7 +17218,7 @@ a@ template void load(size_t offset, multi_ptr ptr) ---- - a@ Loads the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#, into the components of this SYCL [code]#vec#. [code]#vec# must be aligned to the size of the data type of this SYCL vec. + a@ Loads the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#, into the components of this SYCL [code]#vec#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. a@ [source] @@ -17226,7 +17226,7 @@ a@ template void store(size_t offset, multi_ptr ptr) const ---- - a@ Stores the components of this SYCL [code]#vec# into the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#. [code]#vec# must be aligned to the size of the data type of this SYCL vec. + a@ Stores the components of this SYCL [code]#vec# into the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. a@ [source] From f3c9ef62b420545f882d5e5615cd5bd271b26301 Mon Sep 17 00:00:00 2001 From: "atharva.dubey" Date: Wed, 3 Jan 2024 17:27:01 +0000 Subject: [PATCH 3/7] reworded load/store methods of the vec class --- adoc/chapters/programming_interface.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adoc/chapters/programming_interface.adoc b/adoc/chapters/programming_interface.adoc index 51fd1f29..0928f002 100644 --- a/adoc/chapters/programming_interface.adoc +++ b/adoc/chapters/programming_interface.adoc @@ -17218,7 +17218,7 @@ a@ template void load(size_t offset, multi_ptr ptr) ---- - a@ Loads the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#, into the components of this SYCL [code]#vec#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. + a@ Loads [code]#NumElements# elements from consecutive addresses, with the starting address determined by incrementing [code]#ptr# by [code]#offset# provided in terms of number of elements of type [code]#DataT#, into the components of this SYCL [code]#vec#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. a@ [source] @@ -17226,7 +17226,7 @@ a@ template void store(size_t offset, multi_ptr ptr) const ---- - a@ Stores the components of this SYCL [code]#vec# into the values at the address of [code]#ptr# offset in elements of type [code]#DataT# by [code]#NumElements * offset#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. + a@ Stores [code]#NumElements# components of this SYCL [code]#vec# into consecutive addresses, with the starting address determined by incrementing [code]#ptr# by [code]#offset# provided in terms of number of elements of type [code]#DataT#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. a@ [source] From 1b7d154810fcd31cbdd9c85cb4973b753dfe9d06 Mon Sep 17 00:00:00 2001 From: "atharva.dubey" Date: Thu, 4 Jan 2024 09:46:33 +0000 Subject: [PATCH 4/7] corrected definition in previous commit --- adoc/chapters/programming_interface.adoc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/adoc/chapters/programming_interface.adoc b/adoc/chapters/programming_interface.adoc index 0928f002..e8ae881a 100644 --- a/adoc/chapters/programming_interface.adoc +++ b/adoc/chapters/programming_interface.adoc @@ -17218,7 +17218,7 @@ a@ template void load(size_t offset, multi_ptr ptr) ---- - a@ Loads [code]#NumElements# elements from consecutive addresses, with the starting address determined by incrementing [code]#ptr# by [code]#offset# provided in terms of number of elements of type [code]#DataT#, into the components of this SYCL [code]#vec#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. + a@ Loads [code]#NumElements# elements into the components of this SYCL [code]#vec#. These elements are loaded from consecutive addresses, where the starting address is computed by adding [code]#offset * NumElements * sizeof(DataT)# bytes to the address specified by the [code]#ptr#. The ptr must be aligned to [code]#alignof(DataT)#. a@ [source] @@ -17226,7 +17226,7 @@ a@ template void store(size_t offset, multi_ptr ptr) const ---- - a@ Stores [code]#NumElements# components of this SYCL [code]#vec# into consecutive addresses, with the starting address determined by incrementing [code]#ptr# by [code]#offset# provided in terms of number of elements of type [code]#DataT#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. + a@ Stores [code]#NumElements# components of this SYCL [code]#vec# into consecutive addresses, with the starting address determined by adding [code]#offset * NumElements * sizeof(DataT)# to the address specified by the [code]#ptr#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. a@ [source] From 069a4a28c35dc47dc44c2ccaf0b5868f272fbf74 Mon Sep 17 00:00:00 2001 From: "atharva.dubey" Date: Thu, 4 Jan 2024 14:06:59 +0000 Subject: [PATCH 5/7] append acknowledgements list --- adoc/chapters/acknowledgements.adoc | 1 + 1 file changed, 1 insertion(+) diff --git a/adoc/chapters/acknowledgements.adoc b/adoc/chapters/acknowledgements.adoc index 2ce12afa..4eada024 100644 --- a/adoc/chapters/acknowledgements.adoc +++ b/adoc/chapters/acknowledgements.adoc @@ -90,6 +90,7 @@ * Peter Thoman, University of Innsbruck * Biagio Cosenza, University of Salerno * Paul Preney, University of Windsor + * Atharva Dubey, Codeplay // Jon: in other specs we credit Khronos staff who have helped. // Ronan: indeed! Just reading this while actually adding the... Khronos From 1c6822ee43db0778806588b1966aeb12d64777d5 Mon Sep 17 00:00:00 2001 From: "atharva.dubey" Date: Thu, 4 Jan 2024 14:26:06 +0000 Subject: [PATCH 6/7] place name in correct position --- adoc/chapters/acknowledgements.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adoc/chapters/acknowledgements.adoc b/adoc/chapters/acknowledgements.adoc index 4eada024..3a3b8d78 100644 --- a/adoc/chapters/acknowledgements.adoc +++ b/adoc/chapters/acknowledgements.adoc @@ -31,6 +31,7 @@ * Verena Beckham, Codeplay * Aidan Belton, Codeplay * Gordon Brown, Codeplay + * Atharva Dubey, Codeplay * Morris Hafner, Codeplay * Alexander Johnston, Codeplay * Marios Katsigiannis, Codeplay @@ -90,7 +91,6 @@ * Peter Thoman, University of Innsbruck * Biagio Cosenza, University of Salerno * Paul Preney, University of Windsor - * Atharva Dubey, Codeplay // Jon: in other specs we credit Khronos staff who have helped. // Ronan: indeed! Just reading this while actually adding the... Khronos From eb64a5c982fa29004e1db57e1d64429202796c11 Mon Sep 17 00:00:00 2001 From: Atharva Dubey Date: Thu, 11 Jan 2024 15:55:40 +0000 Subject: [PATCH 7/7] add ptr inside code section Co-authored-by: Ronan Keryell --- adoc/chapters/programming_interface.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adoc/chapters/programming_interface.adoc b/adoc/chapters/programming_interface.adoc index 47bf1613..e69dfe2f 100644 --- a/adoc/chapters/programming_interface.adoc +++ b/adoc/chapters/programming_interface.adoc @@ -17230,7 +17230,7 @@ a@ template void load(size_t offset, multi_ptr ptr) ---- - a@ Loads [code]#NumElements# elements into the components of this SYCL [code]#vec#. These elements are loaded from consecutive addresses, where the starting address is computed by adding [code]#offset * NumElements * sizeof(DataT)# bytes to the address specified by the [code]#ptr#. The ptr must be aligned to [code]#alignof(DataT)#. + a@ Loads [code]#NumElements# elements into the components of this SYCL [code]#vec#. These elements are loaded from consecutive addresses, where the starting address is computed by adding [code]#offset * NumElements * sizeof(DataT)# bytes to the address specified by the [code]#ptr#. The [code]#ptr# must be aligned to [code]#alignof(DataT)#. a@ [source]