Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Tags and Potions #3

Open
BioMasterZap opened this issue Mar 7, 2024 · 4 comments
Open

Custom Tags and Potions #3

BioMasterZap opened this issue Mar 7, 2024 · 4 comments

Comments

@BioMasterZap
Copy link

So I have been using custom tags to clean up my REI for a mod pack, but I've recently been trying a potion mod (Awesome Magic) that adds new potion containers, Vials and Jars, and despite tagging them as I've done for other items without issue, I cannot get them to collapse. They aren't showing up under "Potions" by default nor do they seem to have any default tags, but I am able to add tags for all the vials and all the jars using Crafttweaker. But even though it shows in REI that all of them are tagged, if I add the tag to the collapsed list, it doesn't work for any of the vial/jar potions.

I suspect this has something to do with the weird way potions work with NBT or such, but I'm not sure since everything seems to be working except for the collapsing part. I even tried adding the tag for a specific potion with NBT to see if that might do it, but whether I use a new tag or existing tags that already work for collapsing items, it seems the mod just won't work on the potions. If you have any ideas of something I could try differently or know of any reasons this won't/can't work, let me know.

@KrLite
Copy link
Member

KrLite commented Mar 7, 2024

Sure. Wait for me to figure it out.

@KrLite
Copy link
Member

KrLite commented May 1, 2024

It seems that Awesome Magic made huge changes to vanilla potion system (making them stackable, different potion sizes, etc.) and its source code isn't available due to ARR license. It will be hard to compatible, and the issue priority may be low.

@NitrolessWasTaken
Copy link

Having this exact issue but with Sophisticated Storage.

@BioMasterZap
Copy link
Author

Might be worth adding I ran into a similar thing with the Vanilla Fireworks. If I recall right, by default it shows a firework for each flight duration. It seemed I could tag the ones that show in REI but it wouldn't make a collapsible section. Haven't fiddles with it in a few weeks/months, but I figured it was the same or similar as the potion mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants