Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : 중복 코드 제거를 위해 APIResponse 클래스에 변환 메소드 추가 #25 #26

Closed
wants to merge 2 commits into from
Closed

Feat : 중복 코드 제거를 위해 APIResponse 클래스에 변환 메소드 추가 #25 #26

wants to merge 2 commits into from

Conversation

K-KY
Copy link
Collaborator

@K-KY K-KY commented Jan 2, 2025

바로 MERGE하지 마세요! 검토 후 MERGE해야합니다!

✅ 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)

  • 기능 추가

🏆 구현 목표

ResponseEntity 변환 메소드가 중복됨, 하나의 클래스에 변환 메소드 만들거임


📋 구현 사항 설명 (작업한 내용을 상세하게 기록합니다.)

  1. ApiResponse에 응답 엔티티 반환 메소드 추가

🔍 테스트 방법 (변경 사항을 확인하기 위한 테스트 방법을 기술합니다.)

  1. Postman으로 API 호출 테스트

@K-KY K-KY added the ✨ Feature 기능 개발 label Jan 2, 2025
@K-KY K-KY self-assigned this Jan 2, 2025
github-actions[bot]
github-actions bot reviewed Jan 2, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

src/main/java/com/seveneleven/devlens/global/response/APIResponse.java Show resolved Hide resolved
@K-KY K-KY linked an issue Jan 2, 2025 that may be closed by this pull request
[Feat] : ResponseEntity 변환 메소드 중복 제거 #25
Open
2 tasks
github-actions[bot]
github-actions bot reviewed Jan 2, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review by ChatGPT

src/main/java/com/seveneleven/devlens/global/response/APIResponse.java Show resolved Hide resolved
@kdh10806 kdh10806 closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kdh10806 kdh10806 kdh10806 approved these changes

@Eseas Eseas Awaiting requested review from Eseas Eseas is a code owner

@taekminKwon taekminKwon Awaiting requested review from taekminKwon taekminKwon is a code owner

@HiSeungmin HiSeungmin Awaiting requested review from HiSeungmin HiSeungmin is a code owner

@jeongns2611 jeongns2611 Awaiting requested review from jeongns2611 jeongns2611 is a code owner

Assignees

@K-KY K-KY

Labels
✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] : ResponseEntity 변환 메소드 중복 제거
2 participants
@K-KY @kdh10806