From 12554268d2c24f18695aa990560509d26e647657 Mon Sep 17 00:00:00 2001
From: Lieven Hey <lieven.hey@kdab.com>
Date: Mon, 13 May 2024 12:54:20 +0200
Subject: [PATCH] fix: crash if samples have different amount of costs
 associated

If we have a recording with the following layout: A B C where
A: part where function f is accessed
B: list samples
C: part where function g is accessed
then f won't have the lost events cost while g does.
This will cause a crash when the model tries to access it

fixes: #629
---
 src/models/callercalleemodel.h | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/src/models/callercalleemodel.h b/src/models/callercalleemodel.h
index 98d3e4797..7e2d1349b 100644
--- a/src/models/callercalleemodel.h
+++ b/src/models/callercalleemodel.h
@@ -263,16 +263,26 @@ class LocationCostModelImpl : public HashModel<Data::SourceLocationCostMap, Mode
     QVariant cell(int column, int role, const Data::FileLine& fileLine,
                   const Data::LocationCost& costs) const final override
     {
+        // if we have a recording with the following layout: A B C where
+        // A: part where function f is accessed
+        // B: list samples
+        // C: part where function g is accessed
+        // then f won't have the lost events cost while g does.
+        // This will cause a crash when the model tries to access it
+
+        const auto costType = column - NUM_BASE_COLUMNS;
+        auto safeSelfCost = costType < costs.selfCost.size() ? costs.selfCost[costType] : 0;
+        auto safeInclusiceCost = costType < costs.inclusiveCost.size() ? costs.selfCost[costType] : 0;
         if (role == SortRole) {
             if (column == Location) {
                 return QVariant::fromValue(fileLine);
             }
             column -= NUM_BASE_COLUMNS;
             if (column < m_totalCosts.numTypes()) {
-                return costs.selfCost[column];
+                return safeSelfCost;
             }
             column -= m_totalCosts.numTypes();
-            return costs.inclusiveCost[column];
+            return safeInclusiceCost;
         } else if (role == TotalCostRole && column >= NUM_BASE_COLUMNS) {
             column -= NUM_BASE_COLUMNS;
             if (column >= m_totalCosts.numTypes()) {
@@ -289,10 +299,10 @@ class LocationCostModelImpl : public HashModel<Data::SourceLocationCostMap, Mode
             }
             column -= NUM_BASE_COLUMNS;
             if (column < m_totalCosts.numTypes()) {
-                return Util::formatCostRelative(costs.selfCost[column], m_totalCosts.totalCost(column), true);
+                return Util::formatCostRelative(safeSelfCost, m_totalCosts.totalCost(column), true);
             }
             column -= m_totalCosts.numTypes();
-            return Util::formatCostRelative(costs.inclusiveCost[column], m_totalCosts.totalCost(column), true);
+            return Util::formatCostRelative(safeInclusiceCost, m_totalCosts.totalCost(column), true);
         } else if (role == FileLineRole) {
             return QVariant::fromValue(fileLine);
         } else if (role == Qt::ToolTipRole) {